From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39232 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PaWnG-0005sQ-Ga
	for qemu-devel@nongnu.org; Wed, 05 Jan 2011 12:05:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <froydnj@codesourcery.com>) id 1PaWnF-0001C1-2a
	for qemu-devel@nongnu.org; Wed, 05 Jan 2011 12:05:02 -0500
Received: from mail.codesourcery.com ([38.113.113.100]:33244)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <froydnj@codesourcery.com>) id 1PaWnE-0001Bq-Pe
	for qemu-devel@nongnu.org; Wed, 05 Jan 2011 12:05:01 -0500
Date: Wed, 5 Jan 2011 09:04:59 -0800
From: Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] target-ppc: use float32_is_any_nan()
Message-ID: <20110105170458.GD6247@codesourcery.com>
References: <1293970009-2028-1-git-send-email-aurelien@aurel32.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1293970009-2028-1-git-send-email-aurelien@aurel32.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Sun, Jan 02, 2011 at 01:06:49PM +0100, Aurelien Jarno wrote:
> Use the new function float32_is_any_nan() instead of
> float32_is_quiet_nan() || float32_is_signaling_nan().
> 
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Reviewed-by: Nathan Froyd <froydnj@codesourcery.com>

> @@ -1938,7 +1938,7 @@ target_ulong helper_dlmzb (target_ulong high, target_ulong low, uint32_t update_
>  /* If X is a NaN, store the corresponding QNaN into RESULT.  Otherwise,
>   * execute the following block.  */
>  #define DO_HANDLE_NAN(result, x)                \
> -    if (float32_is_quiet_nan(x) || float32_is_signaling_nan(x)) {     \
> +    if (float32_is_any_nan(x)) {                                \
>          CPU_FloatU __f;                                         \
>          __f.f = x;                                              \
>          __f.l = __f.l | (1 << 22);  /* Set QNaN bit. */         \

If you were looking for other cleanups, this could stand a
maybe_silence_nan.

-Nathan