From: Arun R Bharadwaj <arun@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org,
aneesh.kumar@linux.vnet.ibm.com
Subject: [Qemu-devel] Re: [PATCH 03/13] Add callback function to ThreadletWork structure.
Date: Thu, 6 Jan 2011 15:54:09 +0530 [thread overview]
Message-ID: <20110106102409.GA17489@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110105195416.GB9821@stefanha-thinkpad.localdomain>
* Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> [2011-01-05 19:54:17]:
> On Tue, Jan 04, 2011 at 10:57:20AM +0530, Arun R Bharadwaj wrote:
> > +static void aio_thread(ThreadletWork *work)
> > +{
>
> aio_thread() is not a descriptive name here. This isn't the top-level
> thread function, just the work->func. Please choose something like
> handle_aiocb() or handle_work().
>
> > + pid_t pid;
> > + ssize_t ret = 0;
> > + struct qemu_paiocb *aiocb;
> > +
> > + pid = getpid();
> > + aiocb = container_of(work, struct qemu_paiocb, work);
> > + aiocb->active = 1;
>
> aiocb_mutex?
>
I'll take care of this.
-arun
next prev parent reply other threads:[~2011-01-06 10:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 5:27 [Qemu-devel] [PATCH 00/13] Threadlets infrastructure Arun R Bharadwaj
2011-01-04 5:27 ` [Qemu-devel] [PATCH 01/13] Add aiocb_mutex and aiocb_completion Arun R Bharadwaj
2011-01-05 19:53 ` [Qemu-devel] " Stefan Hajnoczi
2011-01-06 10:27 ` Arun R Bharadwaj
2011-01-04 5:27 ` [Qemu-devel] [PATCH 02/13] Introduce work concept in posix-aio-compat.c Arun R Bharadwaj
2011-01-04 5:27 ` [Qemu-devel] [PATCH 03/13] Add callback function to ThreadletWork structure Arun R Bharadwaj
2011-01-05 19:54 ` [Qemu-devel] " Stefan Hajnoczi
2011-01-06 10:24 ` Arun R Bharadwaj [this message]
2011-01-04 5:27 ` [Qemu-devel] [PATCH 04/13] Add ThreadletQueue Arun R Bharadwaj
2011-01-05 19:54 ` [Qemu-devel] " Stefan Hajnoczi
2011-01-07 6:06 ` Arun R Bharadwaj
2011-01-04 5:27 ` [Qemu-devel] [PATCH 05/13] Threadlet: Add submit_work threadlet API Arun R Bharadwaj
2011-01-04 5:27 ` [Qemu-devel] [PATCH 06/13] Threadlet: Add dequeue_work " Arun R Bharadwaj
2011-01-05 19:55 ` [Qemu-devel] " Stefan Hajnoczi
2011-01-06 10:43 ` Arun R Bharadwaj
2011-01-07 11:06 ` Stefan Hajnoczi
2011-01-04 5:27 ` [Qemu-devel] [PATCH 07/13] Remove active field in qemu_aiocb structure Arun R Bharadwaj
2011-01-04 5:27 ` [Qemu-devel] [PATCH 08/13] Remove thread_create routine Arun R Bharadwaj
2011-01-05 19:56 ` [Qemu-devel] " Stefan Hajnoczi
2011-01-07 5:59 ` Arun R Bharadwaj
2011-01-04 5:27 ` [Qemu-devel] [PATCH 09/13] Threadlet: Add aio_signal_handler threadlet API Arun R Bharadwaj
2011-01-04 5:28 ` [Qemu-devel] [PATCH 10/13] Remove all instances of CONFIG_THREAD Arun R Bharadwaj
2011-01-04 5:28 ` [Qemu-devel] [PATCH 11/13] Move threadlet code to qemu-threadlets.c Arun R Bharadwaj
2011-01-04 5:28 ` [Qemu-devel] [PATCH 12/13] Threadlets: Add functionality to create private queues Arun R Bharadwaj
2011-01-04 5:28 ` [Qemu-devel] [PATCH 13/13] Threadlets: Add documentation Arun R Bharadwaj
2011-01-04 23:13 ` [Qemu-devel] [PATCH 00/13] Threadlets infrastructure Venkateswararao Jujjuri (JV)
2011-01-05 1:43 ` Arun R Bharadwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106102409.GA17489@linux.vnet.ibm.com \
--to=arun@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).