From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57508 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pan1A-0004Xf-Gr
	for qemu-devel@nongnu.org; Thu, 06 Jan 2011 05:24:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arun@linux.vnet.ibm.com>) id 1Pan19-0000NX-Fq
	for qemu-devel@nongnu.org; Thu, 06 Jan 2011 05:24:28 -0500
Received: from e23smtp06.au.ibm.com ([202.81.31.148]:44203)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arun@linux.vnet.ibm.com>) id 1Pan18-0000ME-UF
	for qemu-devel@nongnu.org; Thu, 06 Jan 2011 05:24:27 -0500
Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245])
	by e23smtp06.au.ibm.com (8.14.4/8.13.1) with ESMTP id p06ANtM1030256
	for <qemu-devel@nongnu.org>; Thu, 6 Jan 2011 21:23:55 +1100
Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139])
	by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p06AODkJ1523962
	for <qemu-devel@nongnu.org>; Thu, 6 Jan 2011 21:24:14 +1100
Received: from d23av04.au.ibm.com (loopback [127.0.0.1])
	by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p06AODjv028024
	for <qemu-devel@nongnu.org>; Thu, 6 Jan 2011 21:24:13 +1100
Date: Thu, 6 Jan 2011 15:54:09 +0530
From: Arun R Bharadwaj <arun@linux.vnet.ibm.com>
Message-ID: <20110106102409.GA17489@linux.vnet.ibm.com>
References: <20110104052627.15887.43436.stgit@localhost6.localdomain6>
	<20110104052720.15887.59290.stgit@localhost6.localdomain6>
	<20110105195416.GB9821@stefanha-thinkpad.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20110105195416.GB9821@stefanha-thinkpad.localdomain>
Subject: [Qemu-devel] Re: [PATCH 03/13] Add callback function to
	ThreadletWork structure.
Reply-To: arun@linux.vnet.ibm.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, aneesh.kumar@linux.vnet.ibm.com

* Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> [2011-01-05 19:54:17]:

> On Tue, Jan 04, 2011 at 10:57:20AM +0530, Arun R Bharadwaj wrote:
> > +static void aio_thread(ThreadletWork *work)
> > +{
> 
> aio_thread() is not a descriptive name here.  This isn't the top-level
> thread function, just the work->func.  Please choose something like
> handle_aiocb() or handle_work().
> 
> > +    pid_t pid;
> > +    ssize_t ret = 0;
> > +    struct qemu_paiocb *aiocb;
> > +
> > +    pid = getpid();
> > +    aiocb = container_of(work, struct qemu_paiocb, work);
> > +    aiocb->active = 1;
> 
> aiocb_mutex?
> 

I'll take care of this. 

-arun