From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57586 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pauur-0004Wg-6h for qemu-devel@nongnu.org; Thu, 06 Jan 2011 13:50:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pautd-0008WC-Hk for qemu-devel@nongnu.org; Thu, 06 Jan 2011 13:49:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pautd-0008Vs-Ae for qemu-devel@nongnu.org; Thu, 06 Jan 2011 13:49:13 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p06InBgY012811 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 6 Jan 2011 13:49:12 -0500 Date: Thu, 6 Jan 2011 16:48:51 -0200 From: Marcelo Tosatti Message-ID: <20110106184851.GA12327@amt.cnet> References: <20101208171136.GA10213@amt.cnet> <20110105193239.GA27817@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110105193239.GA27817@redhat.com> Subject: [Qemu-devel] Re: acpi_piix4: expose no_hotplug attribute via i/o port List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, Gleb Natapov , Gerd Hoffmann On Wed, Jan 05, 2011 at 09:32:39PM +0200, Michael S. Tsirkin wrote: > On Wed, Dec 08, 2010 at 03:11:36PM -0200, Marcelo Tosatti wrote: > > > > On top of "add hotplug opt-out option for devices" patchset > > http://www.mail-archive.com/qemu-devel@nongnu.org/msg46953.html. > > > > Signed-off-by: Marcelo Tosatti > > > > diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c > > Um, this does not seem to apply to master. > It's at 23979dc5411befabe9049e37075b2b6320debc4e for me. > What am I doing wrong? It applies on top of the PCI no_hotplug patches from Gerd. Once you have those in the pci branch, i can regenerate this one and retest. These should not go through the uq/master branch, that is a KVM support code specific branch. Thanks.