From: Nathan Froyd <froydnj@codesourcery.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Stuart Brady" <sdb@zubnet.me.uk>,
"Andreas Färber" <andreas.faerber@web.de>,
"Riku Voipio" <riku.voipio@iki.fi>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code
Date: Thu, 6 Jan 2011 11:26:56 -0800 [thread overview]
Message-ID: <20110106192655.GR6247@codesourcery.com> (raw)
In-Reply-To: <AANLkTin5w85BvOEHDhjxgpb4aa=qGOKcTYDmjs9h-=o5@mail.gmail.com>
On Thu, Jan 06, 2011 at 03:34:38PM +0000, Peter Maydell wrote:
> Similarly I'm dubious about uses in helper_fsel, helper_fcmpu
> and helper_fcmpo, efsctsi, efsctui, efsctsiz, efsctuiz, efsctsf,
> efsctuf and all the helper_efd* functions. I haven't actually
> checked them all, but for instance efdctsi in the Power ISA
> 2.03 spec says "NaNs are converted as though they were zero",
> but qemu's code says:
> /* NaN are not treated the same way IEEE 754 does */
> if (unlikely(float64_is_quiet_nan(u.d)))
> return 0;
>
> which is not going to do the right thing for signaling NaNs.
I think you are correct about fsel, fcmpu, and fcmpo.
The E500 FP instructions are broken for various corner cases (and there
are a lot of them, because E500 is screwy). I've been meaning to go
through and fix them up, but haven't taken the time to do so.
-Nathan
next prev parent reply other threads:[~2011-01-06 19:28 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 14:34 [Qemu-devel] softfloat: fix NaN propagation for MIPS and PowerPC + cleanup Aurelien Jarno
2011-01-03 14:34 ` [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code Aurelien Jarno
2011-01-03 15:22 ` Peter Maydell
2011-01-03 15:26 ` Aurelien Jarno
2011-01-04 19:54 ` Andreas Färber
2011-01-04 20:07 ` Aurelien Jarno
2011-01-04 22:53 ` Andreas Färber
2011-01-04 23:56 ` Aurelien Jarno
2011-01-05 8:15 ` Andreas Färber
2011-01-05 10:21 ` Aurelien Jarno
2011-01-05 23:13 ` Stuart Brady
2011-01-06 8:58 ` Peter Maydell
2011-01-06 18:13 ` Stuart Brady
2011-01-06 18:43 ` Peter Maydell
2011-01-06 19:25 ` Stuart Brady
2011-01-06 14:35 ` Aurelien Jarno
2011-01-06 15:34 ` Peter Maydell
2011-01-06 18:48 ` Aurelien Jarno
2011-01-06 21:19 ` Peter Maydell
2011-01-06 21:31 ` Aurelien Jarno
2011-01-06 19:26 ` Nathan Froyd [this message]
2011-01-06 13:10 ` Andreas Färber
2011-01-06 15:08 ` Aurelien Jarno
2011-01-03 14:34 ` [Qemu-devel] [PATCH 2/6] softfloat: fix float{32, 64}_maybe_silence_nan() for MIPS Aurelien Jarno
2011-01-03 15:15 ` Peter Maydell
2011-01-03 15:24 ` Aurelien Jarno
2011-01-03 14:34 ` [Qemu-devel] [PATCH 3/6] softfloat: add float{x80, 128}_maybe_silence_nan() Aurelien Jarno
2011-01-03 15:33 ` Peter Maydell
2011-01-03 14:34 ` [Qemu-devel] [PATCH 4/6] softfloat: use float{32, 64, x80, 128}_maybe_silence_nan() Aurelien Jarno
2011-01-03 17:34 ` Peter Maydell
2011-01-03 22:44 ` Aurelien Jarno
2011-01-03 14:34 ` [Qemu-devel] [PATCH 5/6] target-mips: Implement correct NaN propagation rules Aurelien Jarno
2011-01-03 14:34 ` [Qemu-devel] [PATCH 6/6] target-ppc: " Aurelien Jarno
2011-01-05 12:45 ` Nathan Froyd
2011-01-05 17:24 ` [Qemu-devel] " Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106192655.GR6247@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=andreas.faerber@web.de \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=sdb@zubnet.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).