From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49990 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PavVY-0004wf-Un for qemu-devel@nongnu.org; Thu, 06 Jan 2011 14:28:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PavUC-0000qE-1J for qemu-devel@nongnu.org; Thu, 06 Jan 2011 14:27:00 -0500 Received: from mail.codesourcery.com ([38.113.113.100]:33279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PavUB-0000po-Lq for qemu-devel@nongnu.org; Thu, 06 Jan 2011 14:26:59 -0500 Date: Thu, 6 Jan 2011 11:26:56 -0800 From: Nathan Froyd Subject: Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code Message-ID: <20110106192655.GR6247@codesourcery.com> References: <1294065273-30274-2-git-send-email-aurelien@aurel32.net> <151C200F-E9B1-4BDC-B234-C0B03D3086D2@web.de> <20110104200711.GC3615@hall.aurel32.net> <10FC1308-1CC8-41DF-A48C-AD104BCE6E11@web.de> <20110104235604.GD3615@hall.aurel32.net> <072B9AB0-7B44-4A79-80FE-A3D95914AAD4@web.de> <20110105102106.GD15256@volta.aurel32.net> <20110105231306.GA20254@zubnet.me.uk> <20110106143553.GA21099@hall.aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Stuart Brady , Andreas =?iso-8859-1?Q?F=E4rber?= , Riku Voipio , QEMU Developers , Aurelien Jarno On Thu, Jan 06, 2011 at 03:34:38PM +0000, Peter Maydell wrote: > Similarly I'm dubious about uses in helper_fsel, helper_fcmpu > and helper_fcmpo, efsctsi, efsctui, efsctsiz, efsctuiz, efsctsf, > efsctuf and all the helper_efd* functions. I haven't actually > checked them all, but for instance efdctsi in the Power ISA > 2.03 spec says "NaNs are converted as though they were zero", > but qemu's code says: > /* NaN are not treated the same way IEEE 754 does */ > if (unlikely(float64_is_quiet_nan(u.d))) > return 0; > > which is not going to do the right thing for signaling NaNs. I think you are correct about fsel, fcmpu, and fcmpo. The E500 FP instructions are broken for various corner cases (and there are a lot of them, because E500 is screwy). I've been meaning to go through and fix them up, but haven't taken the time to do so. -Nathan