Re: [Qemu-devel] Re: [PATCH] target-arm: fix SMMLA/SMMLS instructions

[Aurelien Jarno <aurelien@aurel32.net>]

On Thu, Jan 06, 2011 at 07:00:09PM +0000, Peter Maydell wrote:
> On 6 January 2011 18:53, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > SMMLA and SMMLS are broken on both in normal and thumb mode, that is
> > both (different) implementations are wrong. They try to avoid a 64-bit
> > add for the rounding, which is not trivial if you want to support both
> > SMMLA and SMMLS with the same code.
> >
> > The code below uses the same implementation for both modes, using the
> > code from the ARM manual. It also fixes the thumb decoding that was a
> > mix between normal and thumb mode.
> >
> > This fixes the issues reported in
> > https://bugs.launchpad.net/qemu/+bug/629298
> >
> > v2: improve comments with the help from Peter Maydell.
> >
> > Cc: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> 
> Confirmed that this is just comment changes since v1, and it
> still passes the tests. So:
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 

Thanks for the review, applied.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net