From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47111 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PaxMA-0007Hp-S1
	for qemu-devel@nongnu.org; Thu, 06 Jan 2011 16:26:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1PaxM8-0003W1-Hb
	for qemu-devel@nongnu.org; Thu, 06 Jan 2011 16:26:49 -0500
Received: from hall.aurel32.net ([88.191.126.93]:57112)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1PaxM8-0003Vj-Cv
	for qemu-devel@nongnu.org; Thu, 06 Jan 2011 16:26:48 -0500
Date: Thu, 6 Jan 2011 22:26:40 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] Re: [PATCH] target-arm: fix SMMLA/SMMLS instructions
Message-ID: <20110106212640.GF15256@volta.aurel32.net>
References: <1294340003-684-1-git-send-email-aurelien@aurel32.net>
	<AANLkTinCMGcE9UEMOj9d65vCEAFLS099EQANOPWQYNsO@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <AANLkTinCMGcE9UEMOj9d65vCEAFLS099EQANOPWQYNsO@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

On Thu, Jan 06, 2011 at 07:00:09PM +0000, Peter Maydell wrote:
> On 6 January 2011 18:53, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > SMMLA and SMMLS are broken on both in normal and thumb mode, that is
> > both (different) implementations are wrong. They try to avoid a 64-bit
> > add for the rounding, which is not trivial if you want to support both
> > SMMLA and SMMLS with the same code.
> >
> > The code below uses the same implementation for both modes, using the
> > code from the ARM manual. It also fixes the thumb decoding that was a
> > mix between normal and thumb mode.
> >
> > This fixes the issues reported in
> > https://bugs.launchpad.net/qemu/+bug/629298
> >
> > v2: improve comments with the help from Peter Maydell.
> >
> > Cc: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> 
> Confirmed that this is just comment changes since v1, and it
> still passes the tests. So:
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 

Thanks for the review, applied.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net