From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56310 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PbAii-00014w-Ul
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 06:43:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PbAii-0006Ix-0R
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 06:43:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:14936)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PbAih-0006IH-Pk
	for qemu-devel@nongnu.org; Fri, 07 Jan 2011 06:42:59 -0500
Date: Fri, 7 Jan 2011 13:42:29 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.
Message-ID: <20110107114228.GA9005@redhat.com>
References: <1291123564-3249-1-git-send-email-kraxel@redhat.com>
	<1291123564-3249-3-git-send-email-kraxel@redhat.com>
	<20110105194406.GC28688@redhat.com> <4D258014.9080309@redhat.com>
	<20110106092959.GA12142@redhat.com> <4D25CE3A.2030209@redhat.com>
	<20110106143438.GA16877@redhat.com>
	<20110106184520.GA12120@amt.cnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110106184520.GA12120@amt.cnet>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>, aurelien@aurel32.net
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On Thu, Jan 06, 2011 at 04:45:20PM -0200, Marcelo Tosatti wrote:
> On Thu, Jan 06, 2011 at 04:34:38PM +0200, Michael S. Tsirkin wrote:
> > On Thu, Jan 06, 2011 at 03:14:18PM +0100, Gerd Hoffmann wrote:
> > >   Hi,
> > > 
> > > >Could you split the tested and untested parts to separate patches,
> > > >noting the status in the commit message?
> > > 
> > > I think this is overkill given how simple the change is.
> > 
> > Yes but I don't know whether the untested devices this
> > patch touches are intended to be non hotpluggable.
> > I guess, I'll just ack the pci.c part and let Anthony deal
> > with this.
> 
> Michael,
> 
> PCI hotplug is only supported on x86 via ACPI, and there the piix 
> devices are not hotpluggable.

Aurelien, could you ack the piix4 bit please?

-- 
MST