From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, jan.kiszka@web.de, quintela@redhat.com
Subject: [Qemu-devel] [PATCH V2] savevm: use error_report for vmstate_save error
Date: Fri, 07 Jan 2011 08:58:37 -0700 [thread overview]
Message-ID: <20110107155817.12891.70829.stgit@s20.home> (raw)
In-Reply-To: <20110107071815.26658.403.stgit@s20.home>
If migration is done in the background with the -d option, mon is
NULL and this error message is lost. Instead use error_report().
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
savevm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/savevm.c b/savevm.c
index 90aa237..148871d 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1543,7 +1543,7 @@ int qemu_savevm_state_complete(Monitor *mon, QEMUFile *f)
r = vmstate_save(f, se);
if (r < 0) {
- monitor_printf(mon, "cannot migrate with device '%s'\n", se->idstr);
+ error_report("cannot migrate with device '%s'\n", se->idstr);
return r;
}
}
next prev parent reply other threads:[~2011-01-07 15:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 7:18 [Qemu-devel] [PATCH] savevm: print migration failure to stderr rather than monitor Alex Williamson
2011-01-07 8:51 ` [Qemu-devel] " Jan Kiszka
2011-01-07 15:39 ` Alex Williamson
2011-01-07 15:46 ` Jan Kiszka
2011-01-07 15:56 ` Alex Williamson
2011-01-07 15:58 ` Alex Williamson [this message]
2011-01-07 16:03 ` [Qemu-devel] Re: [PATCH V2] savevm: use error_report for vmstate_save error Jan Kiszka
2011-01-07 16:10 ` Alex Williamson
2011-01-07 16:27 ` Jan Kiszka
2011-01-07 18:41 ` Alex Williamson
2011-01-07 18:39 ` [Qemu-devel] [PATCH v3] savevm: Fix no_migrate Alex Williamson
2011-01-07 18:47 ` [Qemu-devel] " Jan Kiszka
2011-01-09 9:57 ` Michael S. Tsirkin
2011-01-09 11:44 ` Blue Swirl
2011-01-07 22:13 ` [Qemu-devel] [PATCH v4] " Alex Williamson
2011-01-09 10:02 ` [Qemu-devel] " Michael S. Tsirkin
2011-01-09 10:47 ` Michael S. Tsirkin
2011-01-10 17:47 ` Alex Williamson
2011-01-10 21:19 ` Michael S. Tsirkin
2011-01-10 10:24 ` Daniel P. Berrange
2011-01-10 14:52 ` Alex Williamson
2011-01-11 21:39 ` [Qemu-devel] [PATCH v5] " Alex Williamson
2011-01-11 22:39 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107155817.12891.70829.stgit@s20.home \
--to=alex.williamson@redhat.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).