From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55320 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PbEi9-0007Jq-Je for qemu-devel@nongnu.org; Fri, 07 Jan 2011 10:58:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PbEi8-0005tr-Il for qemu-devel@nongnu.org; Fri, 07 Jan 2011 10:58:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PbEi8-0005te-Av for qemu-devel@nongnu.org; Fri, 07 Jan 2011 10:58:40 -0500 From: Alex Williamson Date: Fri, 07 Jan 2011 08:58:37 -0700 Message-ID: <20110107155817.12891.70829.stgit@s20.home> In-Reply-To: <20110107071815.26658.403.stgit@s20.home> References: <20110107071815.26658.403.stgit@s20.home> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH V2] savevm: use error_report for vmstate_save error List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: alex.williamson@redhat.com, jan.kiszka@web.de, quintela@redhat.com If migration is done in the background with the -d option, mon is NULL and this error message is lost. Instead use error_report(). Signed-off-by: Alex Williamson --- savevm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index 90aa237..148871d 100644 --- a/savevm.c +++ b/savevm.c @@ -1543,7 +1543,7 @@ int qemu_savevm_state_complete(Monitor *mon, QEMUFile *f) r = vmstate_save(f, se); if (r < 0) { - monitor_printf(mon, "cannot migrate with device '%s'\n", se->idstr); + error_report("cannot migrate with device '%s'\n", se->idstr); return r; } }