From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52030 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PcDi6-0000Kv-58
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 04:06:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1PcDhk-00035J-3E
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 04:06:21 -0500
Received: from mail-ww0-f53.google.com ([74.125.82.53]:49182)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1PcDhj-00035B-T0
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 04:06:20 -0500
Received: by wwi18 with SMTP id 18so19446970wwi.10
	for <qemu-devel@nongnu.org>; Mon, 10 Jan 2011 01:06:18 -0800 (PST)
Date: Mon, 10 Jan 2011 10:06:14 +0100
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20110110090614.GA1750@edde.se.axis.com>
References: <AANLkTikHidY=BkKDjUbOAp=tNvGYBq=Z7Wsdzk4amBYA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTikHidY=BkKDjUbOAp=tNvGYBq=Z7Wsdzk4amBYA@mail.gmail.com>
Subject: [Qemu-devel] Re: [PATCH] cris: remove a write-only variable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Sun, Jan 09, 2011 at 04:56:59PM +0000, Blue Swirl wrote:
> Avoid a warning with GCC 4.6.0:
> /src/qemu/target-cris/translate.c: In function 'gen_intermediate_code_internal':
> /src/qemu/target-cris/translate.c:3185:25: error: variable
> 'orig_flags' set but not used [-Werror=unused-but-set-variable]

Hi,

Looks good but you are using spaces in a tab only file. I don't mind
much but it's maybe better to switch to entirely to spaces or not
at all.

Cheers


> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
>  target-cris/translate.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/target-cris/translate.c b/target-cris/translate.c
> index 5184155..21983eb 100644
> --- a/target-cris/translate.c
> +++ b/target-cris/translate.c
> @@ -3182,7 +3182,7 @@ gen_intermediate_code_internal(CPUState *env,
> TranslationBlock *tb,
>  {
>  	uint16_t *gen_opc_end;
>     	uint32_t pc_start;
> -	unsigned int insn_len, orig_flags;
> +        unsigned int insn_len;
>  	int j, lj;
>  	struct DisasContext ctx;
>  	struct DisasContext *dc = &ctx;
> @@ -3224,8 +3224,8 @@ gen_intermediate_code_internal(CPUState *env,
> TranslationBlock *tb,
>  	dc->cc_size_uptodate = -1;
> 
>  	/* Decode TB flags.  */
> -	orig_flags = dc->tb_flags = tb->flags & (S_FLAG | P_FLAG | U_FLAG \
> -					| X_FLAG | PFIX_FLAG);
> +        dc->tb_flags = tb->flags & (S_FLAG | P_FLAG | U_FLAG | X_FLAG \
> +                                    | PFIX_FLAG);
>  	dc->delayed_branch = !!(tb->flags & 7);
>  	if (dc->delayed_branch)
>  		dc->jmp = JMP_INDIRECT;
> -- 
> 1.6.2.4