From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59127 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PcEvq-0003Xi-0L
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 05:24:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1PcEvp-0002Mh-0E
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 05:24:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:65008)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1PcEvo-0002MQ-J7
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 05:24:56 -0500
Date: Mon, 10 Jan 2011 10:24:50 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20110110102450.GA2723@redhat.com>
References: <20110107183518.13483.52633.stgit@s20.home>
	<20110107220801.15395.38757.stgit@s20.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20110107220801.15395.38757.stgit@s20.home>
Subject: [Qemu-devel] Re: [PATCH v4] savevm: Fix no_migrate
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: mst@redhat.com, jan.kiszka@web.de, qemu-devel@nongnu.org, quintela@redhat.com

On Fri, Jan 07, 2011 at 03:13:25PM -0700, Alex Williamson wrote:
> The no_migrate save state flag is currently only checked in the
> last phase of migration.  This means that we potentially waste
> a lot of time and bandwidth with the live state handlers before
> we ever check the no_migrate flags.  The error message printed
> when we catch a non-migratable device doesn't get printed for
> a detached migration.  And, no_migrate does nothing to prevent
> an incoming migration to a target that includes a non-migratable
> device.  This attempts to fix all of these.
> 
> One notable difference in behavior is that an outgoing migration
> now checks for non-migratable devices before ever connecting to
> the target system.  This means the target will remain listening
> rather than exit from failure.
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
> 
> v4:
>   - fix braces noted by Jan
>   - return error from qemu_savevm_state_blocked rather than fixed EINVAL
>     at qemu_loadvm_state(), since it'a already using errno values
> 
> v3:
> 
> Daniel, adding you to see if libvirt cares about the difference in
> whether the target exits on migration failure as noted above.

If the 'migrate' command on the source QEMU returns an error,
then libvirt will teardown the target QEMU automatically, so
that's not a problem.

Regards,
Daniel