From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35996 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PcK06-0007dC-Ct
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 10:49:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1PcK05-00081S-7e
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 10:49:42 -0500
Received: from mx1.redhat.com ([209.132.183.28]:24627)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1PcK04-00081D-Vg
	for qemu-devel@nongnu.org; Mon, 10 Jan 2011 10:49:41 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0AFndUo004849
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 10 Jan 2011 10:49:39 -0500
Date: Mon, 10 Jan 2011 15:49:34 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/6] spice: client migration.
Message-ID: <20110110154934.GP2723@redhat.com>
References: <1294666311-23457-1-git-send-email-kraxel@redhat.com>
	<1294666311-23457-3-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1294666311-23457-3-git-send-email-kraxel@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, Jan 10, 2011 at 02:31:47PM +0100, Gerd Hoffmann wrote:
> Handle spice client migration, i.e. inform a spice client connected
> about the new host and connection parameters, so it can move over the
> connection automatically.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hmp-commands.hx |   20 ++++++++++++++++++++
>  qmp-commands.hx |   35 +++++++++++++++++++++++++++++++++++
>  ui/qemu-spice.h |    1 +
>  ui/spice-core.c |   40 ++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 96 insertions(+), 0 deletions(-)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index df134f8..e6d8f36 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -815,6 +815,26 @@ ETEXI
>      },
>  
>  STEXI
> +@item spice_migrate_info @var{hostname} @var{port} @var{tls-port} @var{cert-subject}
> +@findex spice_migrate_info
> +Set the spice connection info for the migration target.  The spice
> +server will ask the spice client to automatically reconnect using the
> +new parameters (if specified) once the vm migration finished
> +successfully.
> +ETEXI


> +
> +#if defined(CONFIG_SPICE)
> +    {
> +        .name       = "spice_migrate_info",
> +        .args_type  = "hostname:s,port:i?,tls-port:i?,cert-subject:s?",
> +        .params     = "hostname port tls-port cert-subject",
> +        .help       = "send migration info to spice client",
> +        .user_print = monitor_user_noop,
> +        .mhandler.cmd_new = mon_spice_migrate,
> +    },
> +#endif
> +
> +STEXI
>  @item snapshot_blkdev
>  @findex snapshot_blkdev
>  Snapshot device, using snapshot file as target if provided
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index 56c4d8b..24ada04 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -503,6 +503,41 @@ EQMP
>      },
>  
>  SQMP
> +spice_migrate_info
> +------------------
> +
> +Set the spice connection info for the migration target.  The spice
> +server will ask the spice client to automatically reconnect using the
> +new parameters (if specified) once the vm migration finished
> +successfully.
> +
> +Arguments:
> +
> +- "hostname":     migration target hostname (json-string)
> +- "port":         spice tcp port for plaintext channels (json-int, optional)
> +- "tls-port":     spice tcp port for tls-secured channels (json-int, optional)
> +- "cert-subject": server certificate subject (json-string, optional)
> +
> +Example:
> +
> +-> { "execute": "spice_migrate_info",
> +     "arguments": { "hostname": "virt42.lab.kraxel.org", "port": 1234 } }
> +<- { "return": {} }

I'm wondering whether we should make this command more
generic, because I could likely write up a VNC extension
that provides the same functionality that SPICE has here.
so, 'graphics_migrate_info @var{spice|vnc|...} ...other vars..'

Regards,
Daniel