From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34416 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcKS7-0000Ej-9P for qemu-devel@nongnu.org; Mon, 10 Jan 2011 11:18:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PcKRr-0007Pq-9n for qemu-devel@nongnu.org; Mon, 10 Jan 2011 11:18:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PcKRr-0007Pf-2h for qemu-devel@nongnu.org; Mon, 10 Jan 2011 11:18:23 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0AGILCG022238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 10 Jan 2011 11:18:22 -0500 Date: Mon, 10 Jan 2011 16:18:17 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH 2/6] spice: client migration. Message-ID: <20110110161817.GQ2723@redhat.com> References: <1294666311-23457-1-git-send-email-kraxel@redhat.com> <1294666311-23457-3-git-send-email-kraxel@redhat.com> <20110110154934.GP2723@redhat.com> <20110110155712.GA17952@playa.tlv.redhat.com> <4D2B2F08.9060103@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4D2B2F08.9060103@redhat.com> Reply-To: "Daniel P. Berrange" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Mon, Jan 10, 2011 at 05:08:40PM +0100, Gerd Hoffmann wrote: > On 01/10/11 16:57, Alon Levy wrote: > >>>+spice_migrate_info > >>>+------------------ > >>>+ > >>>+Set the spice connection info for the migration target. The spice > >>>+server will ask the spice client to automatically reconnect using the > >>>+new parameters (if specified) once the vm migration finished > >>>+successfully. > >>>+ > >>>+Arguments: > >>>+ > >>>+- "hostname": migration target hostname (json-string) > >>>+- "port": spice tcp port for plaintext channels (json-int, optional) > >>>+- "tls-port": spice tcp port for tls-secured channels (json-int, optional) > >>>+- "cert-subject": server certificate subject (json-string, optional) > >>>+ > >>>+Example: > >>>+ > >>>+-> { "execute": "spice_migrate_info", > >>>+ "arguments": { "hostname": "virt42.lab.kraxel.org", "port": 1234 } } > >>>+<- { "return": {} } > >> > >>I'm wondering whether we should make this command more > >>generic, because I could likely write up a VNC extension > >>that provides the same functionality that SPICE has here. > >>so, 'graphics_migrate_info @var{spice|vnc|...} ...other vars..' > > > >Considering it isn't actually just graphics how about client_migrate_info? > > I like client_migrate_info and it fits both spice+vnc naming too. > > Given that vnc just needs hostname and port (which are present > already) and the arguments not used by vnc are optional all we need > to do is rename the command and add a "protocol" argument similar to > "set_password", correct? Yeah, that sounds sufficient to me. Regards, Daniel