From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54423 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PcWbB-0004Gg-LP
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 00:16:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1PcWb9-0004tw-NJ
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 00:16:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:8195)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1PcWb9-0004tP-GP
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 00:16:47 -0500
Date: Tue, 11 Jan 2011 10:46:41 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev
	properties for documentation
Message-ID: <20110111051641.GC14930@amit-x200.redhat.com>
References: <cover.1294143626.git.amit.shah@redhat.com>
	<cover.1294143626.git.amit.shah@redhat.com>
	<ad5771296c1d502d349fe8225f09324323b9fcf7.1294143628.git.amit.shah@redhat.com>
	<m3pqs4bzjp.fsf@blackfin.pond.sub.org>
	<4D2B9DF6.4080908@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D2B9DF6.4080908@windriver.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chris Krumme <Chris.Krumme@windriver.com>
Cc: qemu-devel@nongnu.org

On (Mon) Jan 10 2011 [18:01:58], Chris Krumme wrote:
> On 01/10/2011 08:31 AM, Markus Armbruster wrote:
> >Amit Shah<amit.shah@redhat.com>  writes:
> >
> >[...]
> >>diff --git a/hw/qdev.c b/hw/qdev.c
> >>index 6fc9b02..168d0f6 100644
> >>--- a/hw/qdev.c
> >>+++ b/hw/qdev.c
> >>@@ -185,7 +185,8 @@ int qdev_device_help(QemuOpts *opts)
> >>          if (!prop->info->parse) {
> >>              continue;           /* no way to set it, don't show */
> >>          }
> >>-        error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name);
> >>+        error_printf("%s.%s=%s, %s\n", info->name, prop->name,
> >>+                     prop->info->name, prop->desc ?: "");
> Hello Amit,
> 
> Do we want to add the GCCism here of ?:?

We already depend on a lot of gcc-specific things, and I believe we have
?: elsewhere as well.

		Amit