qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@gmail.com,
	Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] RFC: QMP event notification for disk media eject
Date: Tue, 11 Jan 2011 11:11:48 -0200	[thread overview]
Message-ID: <20110111111148.1b94b4a4@doriath> (raw)

Hi there,

I need feedback on a new QMP event.

Problem
=======

There's no way for a management tool to detect that a guest OS has ejected the
media in a CDROM or Floppy disk drive (I'm discarding polling, because it's
undesirable at best).

The end result is that the management tool can get confused, this is happening
with libvirt when migration is involved: if the guest is saved/restored or
migrated, then libvirt will start the guest again with media still present.

NOTE: Most of the analysis here was done by Daniel Berrange.

Solution
========

We need a new QMP event to solve that. There are two possible events, a
general one and a very specific one.

There are 3 scenarios in which both events should be emitted:

 1. When guest OS ejects media
 2. When 'eject' monitor command is run
 3. When 'change' monitor command is run

BLOCK_MEDIA_CHANGE
------------------

This is the general event, it's emitted when any removable block device
is changed.

Ideally, the event should contain two pieces of info:

 - qdev device name
 - new file path (to allow distinguishing eject from change)

Example:

  { "event": "BLOCK_MEDIA_CHANGE", "data": { "qdev-id": "myid",
                                             "new-path": "/foo/bar/dir/distro.iso" },
                                             ... }

BLOCK_MEDIA_EJECT
-----------------

This event is only emitted when a CDROM or a floppy disk is ejected.

The event contains one info one:

 - device name

Example:

  { "event": "BLOCK_MEDIA_EJECT", "data": { "device-name": "ide1-cd0" }, ... }

             reply	other threads:[~2011-01-11 13:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-11 13:11 Luiz Capitulino [this message]
2011-01-11 13:28 ` [Qemu-devel] Re: RFC: QMP event notification for disk media eject Kevin Wolf
2011-01-11 17:45   ` Luiz Capitulino
2011-01-11 18:21     ` Daniel P. Berrange
2011-01-11 14:06 ` Anthony Liguori
2011-01-11 14:29   ` Markus Armbruster
2011-01-11 17:47     ` Luiz Capitulino
2011-01-11 14:13 ` [Qemu-devel] " Markus Armbruster
2011-01-11 17:53   ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110111111148.1b94b4a4@doriath \
    --to=lcapitulino@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).