From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] ioeventfd: error handling cleanup
Date: Tue, 11 Jan 2011 15:08:16 +0000 [thread overview]
Message-ID: <20110111150813.GA13894@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <20110111114917.GA8269@redhat.com>
On Tue, Jan 11, 2011 at 01:49:18PM +0200, Michael S. Tsirkin wrote:
> - Don't return status from start/stop functions where it's ignored
> - report errors to make debugging easier
> - assert on unexpected failures
> - don't disable notifiers on error so that we'll
> retry when guest driver restarts
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
I tested migration of a running RHEL 6 install. I also tried running
with TCG instead of KVM and we fall back to ioeventfd=off correctly
there.
Stefan
prev parent reply other threads:[~2011-01-11 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 11:49 [Qemu-devel] [PATCH] ioeventfd: error handling cleanup Michael S. Tsirkin
2011-01-11 15:08 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111150813.GA13894@stefanha-thinkpad.localdomain \
--to=stefanha@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).