From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46047 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pcfpo-0004pD-DQ
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 10:08:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1Pcfpm-0000nI-Uf
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 10:08:32 -0500
Received: from mtagate4.uk.ibm.com ([194.196.100.164]:52245)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@linux.vnet.ibm.com>) id 1Pcfpm-0000mO-Ij
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 10:08:30 -0500
Received: from d06nrmr1707.portsmouth.uk.ibm.com
	(d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225])
	by mtagate4.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p0BF8QXq029376
	for <qemu-devel@nongnu.org>; Tue, 11 Jan 2011 15:08:26 GMT
Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com
	[9.149.37.252])
	by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id p0BF8Tq31147134
	for <qemu-devel@nongnu.org>; Tue, 11 Jan 2011 15:08:29 GMT
Received: from d06av11.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av11.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id p0BF8QoD020573
	for <qemu-devel@nongnu.org>; Tue, 11 Jan 2011 08:08:26 -0700
Date: Tue, 11 Jan 2011 15:08:16 +0000
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Message-ID: <20110111150813.GA13894@stefanha-thinkpad.localdomain>
References: <20110111114917.GA8269@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110111114917.GA8269@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] ioeventfd: error handling cleanup
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, Jan 11, 2011 at 01:49:18PM +0200, Michael S. Tsirkin wrote:
> - Don't return status from start/stop functions where it's ignored
> - report errors to make debugging easier
> - assert on unexpected failures
> - don't disable notifiers on error so that we'll
>   retry when guest driver restarts
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Acked-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

I tested migration of a running RHEL 6 install.  I also tried running
with TCG instead of KVM and we fall back to ioeventfd=off correctly
there.

Stefan