From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60750 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pcgoj-0005Ic-5h
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 11:12:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1PcgnU-0007KC-MO
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 11:11:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50523)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1PcgnU-0007K6-9d
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 11:10:12 -0500
Date: Tue, 11 Jan 2011 21:08:18 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110111153818.GA4092@amit-x200.redhat.com>
References: <cover.1294743490.git.amit.shah@redhat.com>
	<0f9330ee99fb9d11639a98d5fb9c01625a15822e.1294743490.git.amit.shah@redhat.com>
	<4D2C6BB2.206@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D2C6BB2.206@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 2/5] char: Introduce
	char_set/remove_fd_handlers()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Paul Brook <paul@codesourcery.com>

On (Tue) Jan 11 2011 [15:39:46], Gerd Hoffmann wrote:
> On 01/11/11 12:10, Amit Shah wrote:
> >Introduce a char-specific wrapper to qemu_set_fd_handler functions.
> >This wrapper is useful to add / remove a write handler easily.  Write
> >handlers are only used when the backend is blocked and cannot receive
> >any more input.
> 
> I'd suggest to add flags to enable/disable handlers to
> IOHandlerRecord instead.  And helper functions to set/clear them of
> course.
> 
> With that in place you also can move the handlers to a separate
> struct simliar to the new QemuChrHandlers struct from patch #1.

I'm planning to do that later -- when more backends get involved, which
have multiple fds (one for in, one for out).

Are you OK with this for now (to solve the immediate bugs of guests
freezing if host can't flush data) and doing this cleanup later as we
progress?

		Amit