From: Michael Walle <michael@walle.cc>
To: "Schildbach, Wolfgang" <WSCHI@dolby.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] audio: split sample conversion and volumemixing
Date: Tue, 11 Jan 2011 23:50:55 +0100 [thread overview]
Message-ID: <201101112350.55791.michael@walle.cc> (raw)
In-Reply-To: <F49BF8E684BC6C4188D1D63513C4CA070DB3085C@sparrow.dolby.net>
Hi Wolfgang,
> The fixed point path for scaling in mixeng_volume() seems to be under by
> a factor of two, IMHO. The right shift should be by 31, not 32. (Because
> the volume, which I assume is a signed 32 bit integer, can be 0.5 at
> most).
I must admit i just copied the shift from the original define. But the volume
and the samples are signed 64bit values.
@malc: any comments on this?
> Does the code work with FLOAT_MIXENG undefined?
At least for my input voice, it works with integer arithmetic.
--
Michael
next prev parent reply other threads:[~2011-01-11 22:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 23:05 [Qemu-devel] audio: Mixing engine and mixer emulation Michael Walle
2011-01-04 0:08 ` [Qemu-devel] " malc
2011-01-05 0:05 ` [Qemu-devel] [PATCH] audio: split sample conversion and volume mixing Michael Walle
2011-01-10 20:43 ` [Qemu-devel] " Jan Kiszka
2011-01-10 20:52 ` malc
2011-01-10 20:54 ` Jan Kiszka
2011-01-11 6:09 ` [Qemu-devel] Re: [PATCH] audio: split sample conversion and volumemixing Schildbach, Wolfgang
2011-01-11 22:50 ` Michael Walle [this message]
2011-01-11 23:15 ` malc
2011-01-12 8:24 ` [Qemu-devel] " Schildbach, Wolfgang
2011-01-12 15:44 ` [Qemu-devel] Re: [PATCH] audio: split sample conversion and volume mixing malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101112350.55791.michael@walle.cc \
--to=michael@walle.cc \
--cc=WSCHI@dolby.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).