From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48056 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pcn3J-000079-NQ
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 17:50:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1Pcn3I-00042n-Q5
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 17:50:57 -0500
Received: from mail.serverraum.org ([78.47.150.89]:47959)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <michael@walle.cc>) id 1Pcn3I-00042E-LF
	for qemu-devel@nongnu.org; Tue, 11 Jan 2011 17:50:56 -0500
From: Michael Walle <michael@walle.cc>
Date: Tue, 11 Jan 2011 23:50:55 +0100
References: <alpine.LNX.2.00.1101040305200.4455@linmac>
	<4D2B6F8B.5080302@web.de>
	<F49BF8E684BC6C4188D1D63513C4CA070DB3085C@sparrow.dolby.net>
In-Reply-To: <F49BF8E684BC6C4188D1D63513C4CA070DB3085C@sparrow.dolby.net>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201101112350.55791.michael@walle.cc>
Subject: [Qemu-devel] Re: [PATCH] audio: split sample conversion and
	volumemixing
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Schildbach, Wolfgang" <WSCHI@dolby.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org


Hi Wolfgang,

> The fixed point path for scaling in mixeng_volume() seems to be under by
> a factor of two, IMHO. The right shift should be by 31, not 32. (Because
> the volume, which I assume is a signed 32 bit integer, can be 0.5 at
> most).
I must admit i just copied the shift from the original define. But the volume 
and the samples are signed 64bit values.

@malc: any comments on this?

> Does the code work with FLOAT_MIXENG undefined?
At least for my input voice, it works with integer arithmetic. 

-- 
  Michael