From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50357 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pcu0P-0001cC-UJ
	for qemu-devel@nongnu.org; Wed, 12 Jan 2011 01:16:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Pcu0O-0001SX-QA
	for qemu-devel@nongnu.org; Wed, 12 Jan 2011 01:16:25 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53155)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1Pcu0O-0001SN-JB
	for qemu-devel@nongnu.org; Wed, 12 Jan 2011 01:16:24 -0500
Date: Wed, 12 Jan 2011 11:46:09 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110112061609.GC12381@amit-x200.redhat.com>
References: <cover.1294743490.git.amit.shah@redhat.com>
	<2e63b173956da74c9759b57bddb9d2f01053f8b2.1294743490.git.amit.shah@redhat.com>
	<4D2C5D38.3000606@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D2C5D38.3000606@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 5/5] char: Equip the unix/tcp backend to
 handle nonblocking writes
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu list <qemu-devel@nongnu.org>, Paul Brook <paul@codesourcery.com>

On (Tue) Jan 11 2011 [14:38:00], Paolo Bonzini wrote:
> On 01/11/2011 12:10 PM, Amit Shah wrote:
> >+    char_set_fd_handlers(s->fd, tcp_chr_read_poll, tcp_chr_read,
> >+                         char_write_unblocked, chr, poll_out);
> 
> Would the 4th parameter always be char_write_unblocked?  If so, what
> about making it hidden within char_set_fd_handlers (also because
> char_write_unblocked is static in qemu-char.c).

It could change for other backends, but the plan is to move to a
struct-type declaration even for the fd handlers, like discussed in the
other thread with Gerd.

		Amit