From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60131 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdJvv-00050G-Qi
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 04:57:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yamahata@valinux.co.jp>) id 1PdJvu-0000DE-PY
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 04:57:31 -0500
Received: from mail.valinux.co.jp ([210.128.90.3]:41793)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yamahata@valinux.co.jp>) id 1PdJvu-0000D4-DI
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 04:57:30 -0500
Date: Thu, 13 Jan 2011 18:57:25 +0900
From: Isaku Yamahata <yamahata@valinux.co.jp>
Subject: Re: [Qemu-devel] [PATCH 0/8] misc cleanups for x86_64 disabling
	config settings
Message-ID: <20110113095725.GA14653@valinux.co.jp>
References: <1294900477-23722-1-git-send-email-daahern@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1294900477-23722-1-git-send-email-daahern@cisco.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Ahern <daahern@cisco.com>
Cc: qemu-devel@nongnu.org

How about creating stub functions instead of #ifdefs?
something like

pc-stubs.c
#ifndef CONFIG_VMWARE_VGA
pci_vmsvga_init()
{
	error ...
}
#endif
#ifndef CONFIG_...
...


On Wed, Jan 12, 2011 at 11:34:29PM -0700, David Ahern wrote:
> David Ahern (8):
>   fix 'no such file' error from make_device_config.sh
>   x86_64 config: fix compile for CONFIG_VMWARE_VGA=n
>   x86_64 config: fix compile for CONFIG_PARALLEL=n
>   remove unused parallel_* variables from pc.c
>   x86_64 config: fix compile for CONFIG_NE2000_ISA=n
>   x86_64 config: fix compile for CONFIG_VGA_ISA=n
>   x86_64 config: fix compile for CONFIG_IDE_ISA=n
>   x86_64 config: fix compile for CONFIG_FDC=n
> 
>  hw/pc.c               |   21 ++++++++++++++++++---
>  hw/pc_piix.c          |   11 +++++++++++
>  make_device_config.sh |    2 +-
>  3 files changed, 30 insertions(+), 4 deletions(-)
> 
> -- 
> 1.7.3.4
> 
> 

-- 
yamahata