From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41420 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PdM4n-0007nk-Dg for qemu-devel@nongnu.org; Thu, 13 Jan 2011 07:14:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PdM4m-0001mM-38 for qemu-devel@nongnu.org; Thu, 13 Jan 2011 07:14:49 -0500 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:51624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PdM4l-0001lR-AV for qemu-devel@nongnu.org; Thu, 13 Jan 2011 07:14:48 -0500 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by e28smtp07.in.ibm.com (8.14.4/8.13.1) with ESMTP id p0DCEh0N022202 for ; Thu, 13 Jan 2011 17:44:43 +0530 Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p0DCEhHK3047456 for ; Thu, 13 Jan 2011 17:44:43 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p0DCEhk6018190 for ; Thu, 13 Jan 2011 23:14:43 +1100 From: Arun R Bharadwaj Date: Thu, 13 Jan 2011 17:44:43 +0530 Message-ID: <20110113121442.4487.37280.stgit@localhost6.localdomain6> In-Reply-To: <20110113120837.4487.95784.stgit@localhost6.localdomain6> References: <20110113120837.4487.95784.stgit@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH 05/12] Threadlet: Add submit_work threadlet API. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, aliguori@linux.vnet.ibm.com, jvrao@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com This patch adds submit work threadlet API and shows how the qemu_paio_submit changes to submit_work. Signed-off-by: Arun R Bharadwaj --- posix-aio-compat.c | 33 ++++++++++++++++++++++----------- 1 files changed, 22 insertions(+), 11 deletions(-) diff --git a/posix-aio-compat.c b/posix-aio-compat.c index b5d70c9..2ab1109 100644 --- a/posix-aio-compat.c +++ b/posix-aio-compat.c @@ -393,13 +393,13 @@ static void spawn_threadlet(ThreadletQueue *queue) if (sigprocmask(SIG_SETMASK, &oldset, NULL)) die("sigprocmask restore"); } -static void qemu_paio_submit(struct qemu_paiocb *aiocb) +/** + * submit_work: Submit to the global queue a new task to be executed + * asynchronously. + * @work: Contains information about the task that needs to be submitted. + */ +static void submit_work(ThreadletWork *work) { - qemu_mutex_lock(&aiocb_mutex); - aiocb->ret = -EINPROGRESS; - aiocb->active = 0; - qemu_mutex_unlock(&aiocb_mutex); - qemu_mutex_lock(&globalqueue.lock); if (!globalqueue_init) { @@ -415,13 +415,13 @@ static void qemu_paio_submit(struct qemu_paiocb *aiocb) } if (globalqueue.idle_threads == 0 && - globalqueue.cur_threads < globalqueue.max_threads) + globalqueue.cur_threads < globalqueue.max_threads) { spawn_threadlet(&globalqueue); - aiocb->work.func = handle_work; - - QTAILQ_INSERT_TAIL(&globalqueue.request_list, &aiocb->work, node); - qemu_cond_signal(&globalqueue.cond); + } else { + qemu_cond_signal(&globalqueue.cond); + } + QTAILQ_INSERT_TAIL(&globalqueue.request_list, work, node); qemu_mutex_unlock(&globalqueue.lock); } @@ -448,6 +448,17 @@ static int qemu_paio_error(struct qemu_paiocb *aiocb) return ret; } +static void qemu_paio_submit(struct qemu_paiocb *aiocb) +{ + qemu_mutex_lock(&aiocb_mutex); + aiocb->ret = -EINPROGRESS; + aiocb->active = 0; + qemu_mutex_unlock(&aiocb_mutex); + + aiocb->work.func = handle_work; + submit_work(&aiocb->work); +} + static int posix_aio_process_queue(void *opaque) { PosixAioState *s = opaque;