From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45112 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PdNsJ-0000pJ-MQ
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 09:10:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1PdNsG-0001yl-Oy
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 09:10:03 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17371)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1PdNsG-0001ye-Fo
	for qemu-devel@nongnu.org; Thu, 13 Jan 2011 09:10:00 -0500
Date: Thu, 13 Jan 2011 19:39:49 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20110113140949.GD19434@amit-x200.redhat.com>
References: <cover.1294923288.git.amit.shah@redhat.com>
	<54967ebf79fdbfdb79f12c2d93608ac260a47795.1294923288.git.amit.shah@redhat.com>
	<4D2F05FD.8060609@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D2F05FD.8060609@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 5/5] iohandlers: Add IOHandlerOps struct
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Paul Brook <paul@codesourcery.com>

On (Thu) Jan 13 2011 [15:02:37], Gerd Hoffmann wrote:
>   Hi,
> 
> >+    ioh->ops.fd_read_poll = ops->fd_read_poll;
> >+    ioh->ops.fd_read = ops->fd_read;
> >+    ioh->ops.fd_write = ops->fd_write;
> 
> You can write this as "ioh->ops = *ops" btw.
> 
> I guess the long-term plan (to be committed after killing the last
> user of the old interface) is to store a pointer to the ops struct
> instead of copying it?

Yes, that's what I have in mind.

		Amit