From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44543 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PeAcL-0002ke-17
	for qemu-devel@nongnu.org; Sat, 15 Jan 2011 13:13:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PeAbK-0001kv-RJ
	for qemu-devel@nongnu.org; Sat, 15 Jan 2011 13:11:47 -0500
Received: from mx1.redhat.com ([209.132.183.28]:4153)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PeAbK-0001ki-KZ
	for qemu-devel@nongnu.org; Sat, 15 Jan 2011 13:11:46 -0500
Date: Sat, 15 Jan 2011 20:11:26 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110115181126.GA27287@redhat.com>
References: <1295114463-13806-1-git-send-email-weil@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1295114463-13806-1-git-send-email-weil@mail.berlios.de>
Subject: [Qemu-devel] Re: [PATCH] pci: Remove unneeded null pointer check
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>, kwolf@redhat.com
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Sat, Jan 15, 2011 at 07:01:03PM +0100, Stefan Weil wrote:
> With bm == NULL, other code in the same function would crash.
> 
> This bug was reported by cppcheck:
> hw/ide/pci.c:280: error: Possible null pointer dereference: bm
> 
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Looks sane. Kevin?

> ---
>  hw/ide/pci.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/ide/pci.c b/hw/ide/pci.c
> index 510b2de..f0db4f2 100644
> --- a/hw/ide/pci.c
> +++ b/hw/ide/pci.c
> @@ -272,9 +272,7 @@ static void bmdma_irq(void *opaque, int n, int level)
>          return;
>      }
>  
> -    if (bm) {
> -        bm->status |= BM_STATUS_INT;
> -    }
> +    bm->status |= BM_STATUS_INT;
>  
>      /* trigger the real irq */
>      qemu_set_irq(bm->irq, level);
> -- 
> 1.7.2.3