From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=35749 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PerUT-0001oX-T4
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 10:59:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1PerUP-0003YO-R5
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 10:59:33 -0500
Received: from verein.lst.de ([213.95.11.210]:43571)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1PerUP-0003Y3-Gb
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 10:59:29 -0500
Date: Mon, 17 Jan 2011 16:59:27 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command
Message-ID: <20110117155927.GA29778@lst.de>
References: <20110114162044.GA19114@lst.de> <20110114162057.GA19184@lst.de>
	<AANLkTi=q3iV15SEZmuXXtMNkfC-udo+0CUS_xZKF3tMP@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTi=q3iV15SEZmuXXtMNkfC-udo+0CUS_xZKF3tMP@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On Mon, Jan 17, 2011 at 11:28:47AM +0000, Stefan Hajnoczi wrote:
> > + ? ?if (bdrv_get_type_hint(bs) == BDRV_TYPE_CDROM) {
> > + ? ? ? ?error_report("Can not resize CDROM devices\n");
> > + ? ? ? ?return -1;
> > + ? ?}
> 
> Hrm...BDRV_TYPE_FLOPPY probably too?

If we want to be consistent, yes.  Or we could remove the CDROM check
and let people shoot themselves in the foot as much as they want.