From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36906 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PerWr-0003eD-Ji
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 11:02:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1PerWp-00048V-VC
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 11:02:01 -0500
Received: from verein.lst.de ([213.95.11.210]:43580)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1PerWp-00048K-5e
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 11:01:59 -0500
Date: Mon, 17 Jan 2011 17:01:48 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] Re: [PATCH] usb-msd: Add usb-storage,
	removable=on|off property
Message-ID: <20110117160148.GA29931@lst.de>
References: <1295049643-23443-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<20110117092126.GB19683@lst.de>
	<20110117100405.GA7123@stefanha-thinkpad.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110117100405.GA7123@stefanha-thinkpad.localdomain>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>, "Justin M. Forbes" <jforbes@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

On Mon, Jan 17, 2011 at 10:04:05AM +0000, Stefan Hajnoczi wrote:
> I was considering not using bdrv_set_removable() and instead adding a
> hint to the BlockDriverState which gets checked when constructing the
> SCSI INQUIRY response.  If we take that approach, then QEMU doesn't
> consider the block device removable in the eject/change medium sense.

I think that's the better approach.  What about moving the removable
qdev property up from the usb driver into the scsi-disk driver?  That's
where it logically belongs, and avoids the need to add another hint.