From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56564 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pf3Q8-0001es-Ab
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 23:43:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arun@linux.vnet.ibm.com>) id 1Pf3Q6-0007mQ-RU
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 23:43:52 -0500
Received: from e23smtp06.au.ibm.com ([202.81.31.148]:42896)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arun@linux.vnet.ibm.com>) id 1Pf3Q6-0007lJ-9y
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 23:43:50 -0500
Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245])
	by e23smtp06.au.ibm.com (8.14.4/8.13.1) with ESMTP id p0I4hHON020975
	for <qemu-devel@nongnu.org>; Tue, 18 Jan 2011 15:43:17 +1100
Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])
	by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p0I4hd9w1470544
	for <qemu-devel@nongnu.org>; Tue, 18 Jan 2011 15:43:39 +1100
Received: from d23av01.au.ibm.com (loopback [127.0.0.1])
	by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	p0I4hdKP022920
	for <qemu-devel@nongnu.org>; Tue, 18 Jan 2011 15:43:39 +1100
Date: Tue, 18 Jan 2011 10:13:34 +0530
From: Arun R Bharadwaj <arun@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler
	threadlet API
Message-ID: <20110118044334.GC21383@linux.vnet.ibm.com>
References: <20110113120837.4487.95784.stgit@localhost6.localdomain6>
	<20110113121458.4487.925.stgit@localhost6.localdomain6>
	<AANLkTimpQmRa+3p65irwYXqVzFgT5Oxj1f9hUyLZh8K-@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <AANLkTimpQmRa+3p65irwYXqVzFgT5Oxj1f9hUyLZh8K-@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Reply-To: arun@linux.vnet.ibm.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, aliguori@linux.vnet.ibm.com, jvrao@linux.vnet.ibm.com, qemu-devel@nongnu.org, aneesh.kumar@linux.vnet.ibm.com

* Stefan Hajnoczi <stefanha@gmail.com> [2011-01-17 09:56:58]:

> On Thu, Jan 13, 2011 at 12:14 PM, Arun R Bharadwaj
> <arun@linux.vnet.ibm.com> wrote:
> > +static void threadlet_io_completion_signal_handler(int signum)
> > +{
> > + =A0 =A0qemu_service_io();
> > +}
> > +
> > +static void threadlet_register_signal_handler(void)
> > +{
> > + =A0 =A0struct sigaction act;
> > + =A0 =A0sigfillset(&act.sa_mask);
> > + =A0 =A0act.sa_flags =3D 0; /* do not restart syscalls to interrupt =
select() */
> > + =A0 =A0act.sa_handler =3D threadlet_io_completion_signal_handler;
> > + =A0 =A0sigaction(SIGUSR2, &act, NULL);
> > +}
> > +
> > +void threadlet_init(void)
> > +{
> > + =A0 =A0threadlet_register_signal_handler();
> > +}
>=20
> This would be the right place to create qemu-threadlet.c, instead of
> adding the thread_init() prototype to qemu-thread.h and then including
> that in vl.c.
>=20
> Stefan

I did not follow your comment here. How can we avoid including
threadler_init() in vl.c?

-arun