From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48336 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PfaKr-0000GH-CW
	for qemu-devel@nongnu.org; Wed, 19 Jan 2011 10:52:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hch@lst.de>) id 1PfaKq-0003Zw-78
	for qemu-devel@nongnu.org; Wed, 19 Jan 2011 10:52:37 -0500
Received: from verein.lst.de ([213.95.11.210]:46587)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hch@lst.de>)
	id 1PfaKp-0003Zl-SG
	for qemu-devel@nongnu.org; Wed, 19 Jan 2011 10:52:36 -0500
Date: Wed, 19 Jan 2011 16:52:34 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command
Message-ID: <20110119155234.GB7394@lst.de>
References: <20110114162044.GA19114@lst.de> <20110114162057.GA19184@lst.de>
	<4D347E0F.4040000@redhat.com> <20110119153544.GA6987@lst.de>
	<4D3707F0.3050608@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4D3707F0.3050608@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>, Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On Wed, Jan 19, 2011 at 04:49:04PM +0100, Kevin Wolf wrote:
> > (qemu) resize scratch 2047 
> > resize scratch 2047 
> > (qemu) 
> > (qemu) resize scrarch 2048
> > resize scrarch 2048
> > invalid size
> > 
> > for l these worked fine.
> 
> Hm, yeah, 'o' uses ssize_t instead of int64_t, so it's broken on a 32
> bit host as well. Though I assume that you use a 64 bit host, and I
> can't really see what's the problem there...

This is a test on a 32-bit host.  The target_long of "l" worked fine
because a kvm enabled qemu always builds for an x86-64 target, even
with a 32-bit host.