From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=35426 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PfVu8-0001qe-6u for qemu-devel@nongnu.org; Wed, 19 Jan 2011 06:08:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PfVu7-0006MQ-0Y for qemu-devel@nongnu.org; Wed, 19 Jan 2011 06:08:43 -0500 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:36719) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PfVu6-0006Kr-F3 for qemu-devel@nongnu.org; Wed, 19 Jan 2011 06:08:42 -0500 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245]) by e23smtp01.au.ibm.com (8.14.4/8.13.1) with ESMTP id p0JB50Zs004563 for ; Wed, 19 Jan 2011 22:05:00 +1100 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p0JB8Uwq2310292 for ; Wed, 19 Jan 2011 22:08:32 +1100 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p0JB8TdG005320 for ; Wed, 19 Jan 2011 22:08:30 +1100 From: "M. Mohan Kumar" Subject: Re: [Qemu-devel] [V3 PATCH 5/8] virtio-9p: Create support in chroot environment Date: Wed, 19 Jan 2011 16:38:23 +0530 References: <1295331799-23856-1-git-send-email-mohan@in.ibm.com> <1295331954-24130-1-git-send-email-mohan@in.ibm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201101191638.24064.mohan@in.ibm.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org Hi Blue Swirl, Thanks for your review comments. I will address these in my next version of patchset. ---- M. Mohan Kumar On Tuesday 18 January 2011 10:38:21 pm Blue Swirl wrote: > On Tue, Jan 18, 2011 at 6:25 AM, M. Mohan Kumar wrote: > > Add both server & client side interfaces to create regular files in > > chroot environment > > > > Signed-off-by: M. Mohan Kumar > > --- > > hw/9pfs/virtio-9p-chroot.c | 42 > > ++++++++++++++++++++++++++++++++++++++++++ hw/9pfs/virtio-9p-local.c | > > 22 ++++++++++++++++++++-- > > 2 files changed, 62 insertions(+), 2 deletions(-) > > > > diff --git a/hw/9pfs/virtio-9p-chroot.c b/hw/9pfs/virtio-9p-chroot.c > > index b599e23..e7f85e2 100644 > > --- a/hw/9pfs/virtio-9p-chroot.c > > +++ b/hw/9pfs/virtio-9p-chroot.c > > @@ -193,6 +193,42 @@ static void chroot_do_open(V9fsFileObjectRequest > > *request, FdInfo *fd_info) } > > } > > > > +/* > > + * Helper routine to create a file and return the file descriptor and > > + * error status in FdInfo structure. > > + */ > > +static void chroot_do_create(V9fsFileObjectRequest *request, FdInfo > > *fd_info) +{ > > + int cur_uid, cur_gid; > > uid_t cur_uid; > gid_t cur_gid; > > > + > > + cur_uid = geteuid(); > > + cur_gid = getegid(); > > + > > + fd_info->fi_fd = -1; > > + > > + if (setfsuid(request->data.uid) < 0) { > > + fd_info->fi_error = errno; > > + return; > > + } > > + if (setfsgid(request->data.gid) < 0) { > > + fd_info->fi_error = errno; > > + goto unset_uid; > > + } > > + > > + fd_info->fi_fd = open(request->path.path, request->data.flags, > > + request->data.mode); > > + > > + if (fd_info->fi_fd < 0) { > > + fd_info->fi_error = errno; > > + } else { > > + fd_info->fi_error = 0; > > + } > > + > > + setfsgid(cur_gid); > > +unset_uid: > > + setfsuid(cur_uid); > > +} > > + > > static int chroot_daemonize(int chroot_sock) > > { > > sigset_t sigset; > > @@ -276,6 +312,12 @@ int v9fs_chroot(FsContext *fs_ctx) > > error = -2; > > } > > break; > > + case T_CREATE: > > + chroot_do_create(&request, &fd_info); > > + if (chroot_sendfd(chroot_sock, &fd_info) <= 0) { > > + error = -2; > > + } > > + break; > > default: > > break; > > } > > diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c > > index 2376ec2..7f39b40 100644 > > --- a/hw/9pfs/virtio-9p-local.c > > +++ b/hw/9pfs/virtio-9p-local.c > > @@ -52,6 +52,23 @@ static int __open(FsContext *fs_ctx, const char *path, > > int flags) return fd; > > } > > > > +static int __create(FsContext *fs_ctx, const char *path, int flags, > > Please don't use identifiers starting with underscores.