From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45278 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pfdew-0003f8-8x
	for qemu-devel@nongnu.org; Wed, 19 Jan 2011 14:25:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Pfdeu-00061i-8M
	for qemu-devel@nongnu.org; Wed, 19 Jan 2011 14:25:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37988)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Pfdeu-00061K-0o
	for qemu-devel@nongnu.org; Wed, 19 Jan 2011 14:25:32 -0500
Date: Wed, 19 Jan 2011 21:25:08 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PULL] piix, pci, qdev
Message-ID: <20110119192508.GA1535@redhat.com>
References: <20101227172140.GA18898@redhat.com>
	<4D2B3CB6.1060802@codemonkey.ws> <20110119151448.GA6121@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110119151448.GA6121@lst.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org

On Wed, Jan 19, 2011 at 04:14:48PM +0100, Christoph Hellwig wrote:
> > >       pci: fix migration path for devices behind bridges
> 
> This patch breaks starting qemu for me on 32-bit x86 with the following assert:

Yes, sorry about that.
I sent a fix, could you check out it please?

> qemu-system-x86_64: savevm.c:1129: register_savevm_live: Assertion
> `!se->compat || se->instance_id == 0' failed.
> 
> my qemu command line is:
> 
> /opt/qemu/bin/qemu-system-x86_64 \
> 	-m 1500 \
> 	-enable-kvm \
> 	-drive if=none,file=/dev/vg01/qemu-root,cache=none,aio=threads,id=root \
> 	-drive if=none,file=/dev/vg01/qemu-data,cache=none,aio=threads,id=test \
> 	-drive if=none,file=/home/test1.img,cache=none,id=scratch \
> 	-device virtio-blk-pci,drive=root \
> 	-device virtio-blk-pci,drive=test \
> 	-device virtio-blk-pci,drive=scratch \
> 	-append "root=/dev/vda console=tty0 console=ttyS0,38400n8" \
> 	-monitor tcp:127.0.0.1:31337,server,nowait \
> 	-kernel arch/x86/boot/bzImage \
> 	-nographic
> 
> btw, I can't find a patch for that commit anywhere in the qemu-devel
> archives.  Did it get reviewed anywhere at all?