From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 0/7] Define "deposit" tcg operation, v2
Date: Thu, 20 Jan 2011 12:31:32 +0100 [thread overview]
Message-ID: <20110120113132.GD19820@edde.se.axis.com> (raw)
In-Reply-To: <1294716228-9299-1-git-send-email-rth@twiddle.net>
On Mon, Jan 10, 2011 at 07:23:41PM -0800, Richard Henderson wrote:
> Changes since v1:
> * No attempt to pack pos+len into one operand. Updated backends
> to match this change.
>
> * Example in the README is a bit more complex.
>
> * Define an official tcg_scratch_alloc routine, used by the i386
> target for the case in which we need a scratch register. I had
> said that triggering this wasn't possible with mainline, but I
> was wrong. The rlwimi example I posted in the other thread hits
> this case.
>
> Aurelien suggested using a shorter name like "dep", but I think that
> would be more confusing than not. This opcode is not really used
> enough to warrent cropping 4 characters, in my opinion.
Thanks Richard. In agreement with Aurelien I've applied patch 1 and 6
as a first step. I've also applied a follow-up patch to fix the
copy-pastos in the README (loc -> len).
Hopefully as more acks come in, we'll apply the rest.
Cheers
prev parent reply other threads:[~2011-01-20 11:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 3:23 [Qemu-devel] [PATCH 0/7] Define "deposit" tcg operation, v2 Richard Henderson
2011-01-11 3:23 ` [Qemu-devel] [PATCH 1/7] tcg: Define "deposit" as an optional operation Richard Henderson
2011-01-11 23:45 ` Aurelien Jarno
2011-01-12 11:00 ` Edgar E. Iglesias
2011-01-11 3:23 ` [Qemu-devel] [PATCH 2/7] tcg-ppc: Implement deposit operation Richard Henderson
2011-01-11 12:40 ` [Qemu-devel] " malc
2011-01-11 16:32 ` Richard Henderson
2011-01-11 19:11 ` malc
2011-01-11 3:23 ` [Qemu-devel] [PATCH 3/7] tcg-hppa: " Richard Henderson
2011-01-11 3:23 ` [Qemu-devel] [PATCH 4/7] tcg-ia64: " Richard Henderson
2011-01-11 3:23 ` [Qemu-devel] [PATCH 5/7] tcg-i386: " Richard Henderson
2011-01-25 12:27 ` Edgar E. Iglesias
2011-01-25 16:13 ` Richard Henderson
2011-01-25 16:48 ` Edgar E. Iglesias
2011-01-25 22:07 ` Richard Henderson
2011-01-26 8:53 ` Edgar E. Iglesias
2011-01-26 9:23 ` Alexander Graf
2011-01-26 15:50 ` Richard Henderson
2011-01-26 16:00 ` Alexander Graf
2011-01-26 16:34 ` Avi Kivity
2011-01-26 16:40 ` Richard Henderson
2011-01-26 16:50 ` Alexander Graf
2011-01-26 18:21 ` Richard Henderson
2011-01-26 18:27 ` Alexander Graf
2011-01-26 18:55 ` Richard Henderson
2011-01-26 19:01 ` Alexander Graf
2011-01-26 19:05 ` Richard Henderson
2011-01-26 19:09 ` Alexander Graf
2011-01-26 19:19 ` Richard Henderson
2011-01-26 19:27 ` Alexander Graf
2011-01-31 8:33 ` Aurelien Jarno
2011-02-08 18:05 ` Richard Henderson
2011-02-09 7:41 ` [Qemu-devel] " Paolo Bonzini
2011-02-09 17:24 ` Blue Swirl
2011-01-11 3:23 ` [Qemu-devel] [PATCH 6/7] target-i386: Use " Richard Henderson
2011-01-12 11:01 ` Edgar E. Iglesias
2011-01-20 11:06 ` Aurelien Jarno
2011-01-11 3:23 ` [Qemu-devel] [PATCH 7/7] target-ppc: " Richard Henderson
2011-01-11 23:45 ` [Qemu-devel] [PATCH 0/7] Define "deposit" tcg operation, v2 Aurelien Jarno
2011-01-20 11:31 ` Edgar E. Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120113132.GD19820@edde.se.axis.com \
--to=edgar.iglesias@gmail.com \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).