From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59251 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pfsjq-0003su-TN
	for qemu-devel@nongnu.org; Thu, 20 Jan 2011 06:31:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Pfsjp-0006No-Nv
	for qemu-devel@nongnu.org; Thu, 20 Jan 2011 06:31:38 -0500
Received: from mail-ww0-f53.google.com ([74.125.82.53]:48725)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1Pfsjp-0006Nc-IN
	for qemu-devel@nongnu.org; Thu, 20 Jan 2011 06:31:37 -0500
Received: by wwi18 with SMTP id 18so452114wwi.10
	for <qemu-devel@nongnu.org>; Thu, 20 Jan 2011 03:31:36 -0800 (PST)
Date: Thu, 20 Jan 2011 12:31:32 +0100
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 0/7] Define "deposit" tcg operation, v2
Message-ID: <20110120113132.GD19820@edde.se.axis.com>
References: <1294716228-9299-1-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1294716228-9299-1-git-send-email-rth@twiddle.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net, agraf@suse.de

On Mon, Jan 10, 2011 at 07:23:41PM -0800, Richard Henderson wrote:
> Changes since v1:
>   * No attempt to pack pos+len into one operand.  Updated backends
>     to match this change.
> 
>   * Example in the README is a bit more complex.
> 
>   * Define an official tcg_scratch_alloc routine, used by the i386
>     target for the case in which we need a scratch register.  I had
>     said that triggering this wasn't possible with mainline, but I
>     was wrong.  The rlwimi example I posted in the other thread hits
>     this case.
> 
> Aurelien suggested using a shorter name like "dep", but I think that
> would be more confusing than not.  This opcode is not really used
> enough to warrent cropping 4 characters, in my opinion.

Thanks Richard. In agreement with Aurelien I've applied patch 1 and 6
as a first step. I've also applied a follow-up patch to fix the
copy-pastos in the README (loc -> len).

Hopefully as more acks come in, we'll apply the rest.

Cheers