From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43197 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pfu92-00013v-Nj for qemu-devel@nongnu.org; Thu, 20 Jan 2011 08:01:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pfu91-0008TV-U8 for qemu-devel@nongnu.org; Thu, 20 Jan 2011 08:01:44 -0500 Received: from verein.lst.de ([213.95.11.210]:60409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pfu91-0008Sy-Lo for qemu-devel@nongnu.org; Thu, 20 Jan 2011 08:01:43 -0500 Date: Thu, 20 Jan 2011 14:01:40 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1 Message-ID: <20110120130140.GA8143@lst.de> References: <1295474688-6219-1-git-send-email-ctang@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1295474688-6219-1-git-send-email-ctang@us.ibm.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunqiang Tang Cc: qemu-devel@nongnu.org On Wed, Jan 19, 2011 at 05:04:44PM -0500, Chunqiang Tang wrote: > Part 1 of the block device driver for the proposed FVD image format. > Multiple patches are used in order to manage the size of each patch. > This patch includes existing files that are modified by FVD. Please try to split the patches into logical parts, and use descriptive subject lines for each patch. E.g. adding the new sim command to qemu-io could be one patch, adding the img_update (why not just update?) command to qemu-img another, moving code into qemu-tool-time.c one more, etc. > - > + Please do not introduce random whitespace changes in patches.