qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] ppc: Fix BookE tlb entry reads
@ 2011-01-21 22:43 Edgar E. Iglesias
  2011-01-21 22:49 ` [Qemu-devel] " Alexander Graf
  0 siblings, 1 reply; 3+ messages in thread
From: Edgar E. Iglesias @ 2011-01-21 22:43 UTC (permalink / raw)
  To: qemu-devel; +Cc: agraf

commit 5823947f9f1e55fb6599c9ed769ce25cdec38355
Author: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Date:   Fri Jan 21 23:12:42 2011 +0100

    ppc: Correct BookE tlb reads
    
    Call the tlb read helper (and not the write helper) for tlb
    reads.
    
    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>

diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 74e06d7..89413c5 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -5874,7 +5874,7 @@ static void gen_tlbre_440(DisasContext *ctx)
     case 2:
         {
             TCGv_i32 t0 = tcg_const_i32(rB(ctx->opcode));
-            gen_helper_440_tlbwe(t0, cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)]);
+            gen_helper_440_tlbre(cpu_gpr[rD(ctx->opcode)], t0, cpu_gpr[rA(ctx->opcode)]);
             tcg_temp_free_i32(t0);
         }
         break;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Qemu-devel] Re: [PATCH] ppc: Fix BookE tlb entry reads
  2011-01-21 22:43 [Qemu-devel] [PATCH] ppc: Fix BookE tlb entry reads Edgar E. Iglesias
@ 2011-01-21 22:49 ` Alexander Graf
  2011-01-21 22:57   ` Edgar E. Iglesias
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Graf @ 2011-01-21 22:49 UTC (permalink / raw)
  To: Edgar E.Iglesias; +Cc: qemu-devel


On 21.01.2011, at 23:43, Edgar E. Iglesias wrote:

> commit 5823947f9f1e55fb6599c9ed769ce25cdec38355
> Author: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> Date:   Fri Jan 21 23:12:42 2011 +0100
> 
>    ppc: Correct BookE tlb reads
> 
>    Call the tlb read helper (and not the write helper) for tlb
>    reads.
> 
>    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>

Acked-by: Alexander Graf <agraf@suse.de>


Alex

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Qemu-devel] Re: [PATCH] ppc: Fix BookE tlb entry reads
  2011-01-21 22:49 ` [Qemu-devel] " Alexander Graf
@ 2011-01-21 22:57   ` Edgar E. Iglesias
  0 siblings, 0 replies; 3+ messages in thread
From: Edgar E. Iglesias @ 2011-01-21 22:57 UTC (permalink / raw)
  To: Alexander Graf; +Cc: qemu-devel

On Fri, Jan 21, 2011 at 11:49:41PM +0100, Alexander Graf wrote:
> 
> On 21.01.2011, at 23:43, Edgar E. Iglesias wrote:
> 
> > commit 5823947f9f1e55fb6599c9ed769ce25cdec38355
> > Author: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> > Date:   Fri Jan 21 23:12:42 2011 +0100
> > 
> >    ppc: Correct BookE tlb reads
> > 
> >    Call the tlb read helper (and not the write helper) for tlb
> >    reads.
> > 
> >    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
> 
> Acked-by: Alexander Graf <agraf@suse.de>

Thanks for the quick ack. Applied.

Cheers

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-01-21 22:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-21 22:43 [Qemu-devel] [PATCH] ppc: Fix BookE tlb entry reads Edgar E. Iglesias
2011-01-21 22:49 ` [Qemu-devel] " Alexander Graf
2011-01-21 22:57   ` Edgar E. Iglesias

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).