From: Aurelien Jarno <aurelien@aurel32.net>
To: Kevin Wolf <mail@kevin-wolf.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] multiboot: Fix upper memory size in multiboot info
Date: Sun, 23 Jan 2011 22:51:28 +0100 [thread overview]
Message-ID: <20110123215128.GF3960@hall.aurel32.net> (raw)
In-Reply-To: <1294146210-14638-1-git-send-email-mail@kevin-wolf.de>
On Tue, Jan 04, 2011 at 02:03:30PM +0100, Kevin Wolf wrote:
> The upper memory size field should exclude the first MB of RAM.
>
> Signed-off-by: Kevin Wolf <mail@kevin-wolf.de>
> ---
> hw/multiboot.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/multiboot.c b/hw/multiboot.c
> index 7cc3055..0d2bfb4 100644
> --- a/hw/multiboot.c
> +++ b/hw/multiboot.c
> @@ -306,7 +306,7 @@ int load_multiboot(void *fw_cfg,
> | MULTIBOOT_FLAGS_MODULES
> | MULTIBOOT_FLAGS_MMAP);
> stl_p(bootinfo + MBI_MEM_LOWER, 640);
> - stl_p(bootinfo + MBI_MEM_UPPER, ram_size / 1024);
> + stl_p(bootinfo + MBI_MEM_UPPER, (ram_size / 1024) - 1024);
> stl_p(bootinfo + MBI_BOOT_DEVICE, 0x8001ffff); /* XXX: use the -boot switch? */
> stl_p(bootinfo + MBI_MMAP_ADDR, ADDR_E820_MAP);
>
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2011-01-23 21:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 13:03 [Qemu-devel] [PATCH] multiboot: Fix upper memory size in multiboot info Kevin Wolf
2011-01-23 21:51 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110123215128.GF3960@hall.aurel32.net \
--to=aurelien@aurel32.net \
--cc=mail@kevin-wolf.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).