From: Isaku Yamahata <yamahata@valinux.co.jp>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH] audio: consolidate audio_init()
Date: Mon, 24 Jan 2011 11:16:21 +0900 [thread overview]
Message-ID: <20110124021621.GA16276@valinux.co.jp> (raw)
In-Reply-To: <844DB33A-4F01-4741-A50D-8BD44AF7B62A@web.de>
On Sun, Jan 23, 2011 at 04:50:34PM +0100, Andreas Färber wrote:
> Am 21.01.2011 um 23:27 schrieb malc:
>
>> On Fri, 21 Jan 2011, Blue Swirl wrote:
>>
>>> On Fri, Jan 21, 2011 at 10:53 AM, Isaku Yamahata
>>> <yamahata@valinux.co.jp> wrote:
>>>> consolidate audio_init() and remove references to shoundhw.
>>>>
>>>> Cc: Blue Swirl <blauwirbel@gmail.com>
>>>> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
>>
>> Don't see the point of first hunk. No objections otherwise.
>
> I guess the point is to limit use of 'soundhw' to arch_init.c rather
> than to anyone including sysemu.h?
> The definition of the struct is moved there and the variable is made
> static.
That's right. Thank you for explanation. I didn't see any reason
why the definition of struct soundhw is used anywhere else.
>
>>>
>>> Acked-by: Blue Swirl <blauwirbel@gmail.com>
>
--
yamahata
next prev parent reply other threads:[~2011-01-24 2:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 10:53 [Qemu-devel] [PATCH] audio: consolidate audio_init() Isaku Yamahata
2011-01-21 20:44 ` [Qemu-devel] " Blue Swirl
2011-01-21 22:27 ` malc
2011-01-23 15:50 ` Andreas Färber
2011-01-24 2:16 ` Isaku Yamahata [this message]
2011-01-25 8:23 ` [Qemu-devel] " Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110124021621.GA16276@valinux.co.jp \
--to=yamahata@valinux.co.jp \
--cc=andreas.faerber@web.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).