From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42115 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PhBym-000240-Kn
	for qemu-devel@nongnu.org; Sun, 23 Jan 2011 21:16:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yamahata@valinux.co.jp>) id 1PhByl-0006Ur-BD
	for qemu-devel@nongnu.org; Sun, 23 Jan 2011 21:16:28 -0500
Received: from mail.valinux.co.jp ([210.128.90.3]:59062)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yamahata@valinux.co.jp>) id 1PhByl-0006Ua-30
	for qemu-devel@nongnu.org; Sun, 23 Jan 2011 21:16:27 -0500
Date: Mon, 24 Jan 2011 11:16:21 +0900
From: Isaku Yamahata <yamahata@valinux.co.jp>
Subject: Re: [Qemu-devel] Re: [PATCH] audio: consolidate audio_init()
Message-ID: <20110124021621.GA16276@valinux.co.jp>
References: <49202e5aabfe119ae7349399dbf59fcbcd1dff97.1295607113.git.yamahata@valinux.co.jp>
	<AANLkTikKoMx8s+vwuvq0qochqByDKFfDTVXn-PDg9m50@mail.gmail.com>
	<alpine.LNX.2.00.1101220126260.1934@linmac>
	<844DB33A-4F01-4741-A50D-8BD44AF7B62A@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <844DB33A-4F01-4741-A50D-8BD44AF7B62A@web.de>
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?utf-8?Q?F=C3=A4rber?= <andreas.faerber@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On Sun, Jan 23, 2011 at 04:50:34PM +0100, Andreas F=C3=A4rber wrote:
> Am 21.01.2011 um 23:27 schrieb malc:
>
>> On Fri, 21 Jan 2011, Blue Swirl wrote:
>>
>>> On Fri, Jan 21, 2011 at 10:53 AM, Isaku Yamahata=20
>>> <yamahata@valinux.co.jp> wrote:
>>>> consolidate audio_init() and remove references to shoundhw.
>>>>
>>>> Cc: Blue Swirl <blauwirbel@gmail.com>
>>>> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
>>
>> Don't see the point of first hunk. No objections otherwise.
>
> I guess the point is to limit use of 'soundhw' to arch_init.c rather =20
> than to anyone including sysemu.h?
> The definition of the struct is moved there and the variable is made =20
> static.

That's right. Thank you for explanation. I didn't see any reason
why the definition of struct soundhw is used anywhere else.

>
>>>
>>> Acked-by: Blue Swirl <blauwirbel@gmail.com>
>

--=20
yamahata