* [Qemu-devel] [PATCH] configure: Fix spice probe
@ 2011-01-24 12:20 Jiri Denemark
2011-01-24 14:01 ` Gerd Hoffmann
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Denemark @ 2011-01-24 12:20 UTC (permalink / raw)
To: qemu-devel
From: Jiri Denemark <Jiri.Denemark@gmail.com>
Non-existent $pkgconfig instead of $pkg_config was used when configure
probes for spice availability.
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
configure | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 210670c..dc469b2 100755
--- a/configure
+++ b/configure
@@ -2207,9 +2207,9 @@ if test "$spice" != "no" ; then
#include <spice.h>
int main(void) { spice_server_new(); return 0; }
EOF
- spice_cflags=$($pkgconfig --cflags spice-protocol spice-server 2>/dev/null)
- spice_libs=$($pkgconfig --libs spice-protocol spice-server 2>/dev/null)
- if $pkgconfig --atleast-version=0.5.3 spice-server >/dev/null 2>&1 && \
+ spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2>/dev/null)
+ spice_libs=$($pkg_config --libs spice-protocol spice-server 2>/dev/null)
+ if $pkg_config --atleast-version=0.5.3 spice-server >/dev/null 2>&1 && \
compile_prog "$spice_cflags" "$spice_libs" ; then
spice="yes"
libs_softmmu="$libs_softmmu $spice_libs"
--
1.7.4.rc2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] configure: Fix spice probe
2011-01-24 12:20 [Qemu-devel] [PATCH] configure: Fix spice probe Jiri Denemark
@ 2011-01-24 14:01 ` Gerd Hoffmann
2011-01-24 14:17 ` Jiri Denemark
2011-01-24 14:20 ` Alon Levy
0 siblings, 2 replies; 6+ messages in thread
From: Gerd Hoffmann @ 2011-01-24 14:01 UTC (permalink / raw)
To: Jiri Denemark; +Cc: qemu-devel
On 01/24/11 13:20, Jiri Denemark wrote:
> From: Jiri Denemark<Jiri.Denemark@gmail.com>
>
> Non-existent $pkgconfig instead of $pkg_config was used when configure
> probes for spice availability.
What tree you are looking at? It _is_ $pkgconfig in mine ...
cheers,
Gerd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Fix spice probe
2011-01-24 14:01 ` Gerd Hoffmann
@ 2011-01-24 14:17 ` Jiri Denemark
2011-01-24 14:20 ` Jiri Denemark
2011-01-24 14:20 ` Alon Levy
1 sibling, 1 reply; 6+ messages in thread
From: Jiri Denemark @ 2011-01-24 14:17 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
On Mon, Jan 24, 2011 at 15:01:27 +0100, Gerd Hoffmann wrote:
> On 01/24/11 13:20, Jiri Denemark wrote:
> > From: Jiri Denemark<Jiri.Denemark@gmail.com>
> >
> > Non-existent $pkgconfig instead of $pkg_config was used when configure
> > probes for spice availability.
>
> What tree you are looking at? It _is_ $pkgconfig in mine ...
Yes, it is. And that's the problem, since $pkgconfig is not ever set inside
configure script. However, $pkg_config is set and used all over the script so
this patch makes spice probe use correct $pkg_config.
Jirka
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Fix spice probe
2011-01-24 14:17 ` Jiri Denemark
@ 2011-01-24 14:20 ` Jiri Denemark
0 siblings, 0 replies; 6+ messages in thread
From: Jiri Denemark @ 2011-01-24 14:20 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
On Mon, Jan 24, 2011 at 15:17:17 +0100, Jiri Denemark wrote:
> On Mon, Jan 24, 2011 at 15:01:27 +0100, Gerd Hoffmann wrote:
> > On 01/24/11 13:20, Jiri Denemark wrote:
> > > From: Jiri Denemark<Jiri.Denemark@gmail.com>
> > >
> > > Non-existent $pkgconfig instead of $pkg_config was used when configure
> > > probes for spice availability.
> >
> > What tree you are looking at? It _is_ $pkgconfig in mine ...
>
> Yes, it is. And that's the problem, since $pkgconfig is not ever set inside
> configure script. However, $pkg_config is set and used all over the script so
> this patch makes spice probe use correct $pkg_config.
Looking at git://git.qemu.org/qemu.git tree.
Jirka
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Fix spice probe
2011-01-24 14:01 ` Gerd Hoffmann
2011-01-24 14:17 ` Jiri Denemark
@ 2011-01-24 14:20 ` Alon Levy
2011-01-24 14:38 ` Gerd Hoffmann
1 sibling, 1 reply; 6+ messages in thread
From: Alon Levy @ 2011-01-24 14:20 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Jiri Denemark, qemu-devel
On Mon, Jan 24, 2011 at 03:01:27PM +0100, Gerd Hoffmann wrote:
> On 01/24/11 13:20, Jiri Denemark wrote:
> >From: Jiri Denemark<Jiri.Denemark@gmail.com>
> >
> >Non-existent $pkgconfig instead of $pkg_config was used when configure
> >probes for spice availability.
>
> What tree you are looking at? It _is_ $pkgconfig in mine ...
And it needs to be $pkg_config - someone did a cleanup and decided to
rename $pkgconfig->$pkg_config recently.
>
> cheers,
> Gerd
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Fix spice probe
2011-01-24 14:20 ` Alon Levy
@ 2011-01-24 14:38 ` Gerd Hoffmann
0 siblings, 0 replies; 6+ messages in thread
From: Gerd Hoffmann @ 2011-01-24 14:38 UTC (permalink / raw)
To: Jiri Denemark, qemu-devel
On 01/24/11 15:20, Alon Levy wrote:
> On Mon, Jan 24, 2011 at 03:01:27PM +0100, Gerd Hoffmann wrote:
>> On 01/24/11 13:20, Jiri Denemark wrote:
>>> From: Jiri Denemark<Jiri.Denemark@gmail.com>
>>>
>>> Non-existent $pkgconfig instead of $pkg_config was used when configure
>>> probes for spice availability.
>>
>> What tree you are looking at? It _is_ $pkgconfig in mine ...
>
> And it needs to be $pkg_config - someone did a cleanup and decided to
> rename $pkgconfig->$pkg_config recently.
Ah, now after rebasing to latest master I see it too.
/me goes pick the patch into the spice queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-01-24 14:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-24 12:20 [Qemu-devel] [PATCH] configure: Fix spice probe Jiri Denemark
2011-01-24 14:01 ` Gerd Hoffmann
2011-01-24 14:17 ` Jiri Denemark
2011-01-24 14:20 ` Jiri Denemark
2011-01-24 14:20 ` Alon Levy
2011-01-24 14:38 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).