From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53880 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PhdsI-0006EC-CN
	for qemu-devel@nongnu.org; Tue, 25 Jan 2011 03:03:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1PhdsG-0002Cc-A1
	for qemu-devel@nongnu.org; Tue, 25 Jan 2011 03:03:38 -0500
Received: from hall.aurel32.net ([88.191.126.93]:47384)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1PhdsG-0002CK-16
	for qemu-devel@nongnu.org; Tue, 25 Jan 2011 03:03:36 -0500
Date: Tue, 25 Jan 2011 09:03:35 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] target-sh4: fix TLB invalidation code
Message-ID: <20110125080335.GC23331@hall.aurel32.net>
References: <1295937121-30652-1-git-send-email-gnurou@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1295937121-30652-1-git-send-email-gnurou@gmail.com>
Sender: Aurelien Jarno <aurelien@aurel32.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: qemu-devel@nongnu.org

On Tue, Jan 25, 2011 at 03:32:01PM +0900, Alexandre Courbot wrote:
> In cpu_sh4_invalidate_tlb, the UTLB was invalidated twice and the
> ITLB left unchaged, probably because of some unfortunate copy/paste.
> 
> Signed-off-by: Alexandre Courbot <gnurou@gmail.com>
> ---
>  target-sh4/helper.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target-sh4/helper.c b/target-sh4/helper.c
> index c34d2f5..aec4d75 100644
> --- a/target-sh4/helper.c
> +++ b/target-sh4/helper.c
> @@ -562,8 +562,8 @@ void cpu_load_tlb(CPUSH4State * env)
>          entry->v = 0;
>      }
>      /* ITLB */
> -    for (i = 0; i < UTLB_SIZE; i++) {
> -        tlb_t * entry = &s->utlb[i];
> +    for (i = 0; i < ITLB_SIZE; i++) {
> +        tlb_t * entry = &s->itlb[i];
>          entry->v = 0;
>      }
>  

Thanks applied.


-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net