* [Qemu-devel] [PATCH] target-sh4: fix TLB invalidation code
@ 2011-01-25 6:32 Alexandre Courbot
2011-01-25 8:03 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Courbot @ 2011-01-25 6:32 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: Alexandre Courbot, qemu-devel
In cpu_sh4_invalidate_tlb, the UTLB was invalidated twice and the
ITLB left unchaged, probably because of some unfortunate copy/paste.
Signed-off-by: Alexandre Courbot <gnurou@gmail.com>
---
target-sh4/helper.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-sh4/helper.c b/target-sh4/helper.c
index c34d2f5..aec4d75 100644
--- a/target-sh4/helper.c
+++ b/target-sh4/helper.c
@@ -562,8 +562,8 @@ void cpu_load_tlb(CPUSH4State * env)
entry->v = 0;
}
/* ITLB */
- for (i = 0; i < UTLB_SIZE; i++) {
- tlb_t * entry = &s->utlb[i];
+ for (i = 0; i < ITLB_SIZE; i++) {
+ tlb_t * entry = &s->itlb[i];
entry->v = 0;
}
--
1.7.3.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] target-sh4: fix TLB invalidation code
2011-01-25 6:32 [Qemu-devel] [PATCH] target-sh4: fix TLB invalidation code Alexandre Courbot
@ 2011-01-25 8:03 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2011-01-25 8:03 UTC (permalink / raw)
To: Alexandre Courbot; +Cc: qemu-devel
On Tue, Jan 25, 2011 at 03:32:01PM +0900, Alexandre Courbot wrote:
> In cpu_sh4_invalidate_tlb, the UTLB was invalidated twice and the
> ITLB left unchaged, probably because of some unfortunate copy/paste.
>
> Signed-off-by: Alexandre Courbot <gnurou@gmail.com>
> ---
> target-sh4/helper.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-sh4/helper.c b/target-sh4/helper.c
> index c34d2f5..aec4d75 100644
> --- a/target-sh4/helper.c
> +++ b/target-sh4/helper.c
> @@ -562,8 +562,8 @@ void cpu_load_tlb(CPUSH4State * env)
> entry->v = 0;
> }
> /* ITLB */
> - for (i = 0; i < UTLB_SIZE; i++) {
> - tlb_t * entry = &s->utlb[i];
> + for (i = 0; i < ITLB_SIZE; i++) {
> + tlb_t * entry = &s->itlb[i];
> entry->v = 0;
> }
>
Thanks applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-25 8:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-25 6:32 [Qemu-devel] [PATCH] target-sh4: fix TLB invalidation code Alexandre Courbot
2011-01-25 8:03 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).