From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2] virtio-pci: Disable virtio-ioeventfd when !CONFIG_IOTHREAD
Date: Tue, 25 Jan 2011 16:56:57 +0200 [thread overview]
Message-ID: <20110125145657.GD15666@redhat.com> (raw)
In-Reply-To: <1295967211-362-1-git-send-email-stefanha@linux.vnet.ibm.com>
On Tue, Jan 25, 2011 at 02:53:31PM +0000, Stefan Hajnoczi wrote:
> It is not possible to use virtio-ioeventfd when building without an I/O
> thread. We rely on a signal to kick us out of vcpu execution. Timers
> and AIO use SIGALRM and SIGUSR2 respectively. Unfortunately eventfd
> does not support O_ASYNC (SIGIO) so eventfd cannot be used in a signal
> driven manner.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
> kvm-all.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 255b6fa..881ea32 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -449,10 +449,14 @@ int kvm_check_extension(KVMState *s, unsigned int extension)
>
> static int kvm_check_many_ioeventfds(void)
> {
> - /* Older kernels have a 6 device limit on the KVM io bus. Find out so we
> + /* Userspace can use ioeventfd for virtqueue kick. This requires a host
virtqueue kick -> io notifications?
> + * that supports eventfd(2) and an I/O thread; since eventfd does not
> + * support SIGIO it cannot interrupt the vcpu.
> + *
> + * Older kernels have a 6 device limit on the KVM io bus. Find out so we
> * can avoid creating too many ioeventfds.
> */
> -#ifdef CONFIG_EVENTFD
> +#if defined(CONFIG_EVENTFD) && defined(CONFIG_IOTHREAD)
> int ioeventfds[7];
> int i, ret = 0;
> for (i = 0; i < ARRAY_SIZE(ioeventfds); i++) {
> --
> 1.7.2.3
next prev parent reply other threads:[~2011-01-25 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 14:53 [Qemu-devel] [PATCH v2] virtio-pci: Disable virtio-ioeventfd when !CONFIG_IOTHREAD Stefan Hajnoczi
2011-01-25 14:56 ` Michael S. Tsirkin [this message]
2011-01-25 16:25 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110125145657.GD15666@redhat.com \
--to=mst@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).