From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59808 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PiJsQ-0005fI-74
	for qemu-devel@nongnu.org; Wed, 26 Jan 2011 23:54:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PiJsN-0007H2-6b
	for qemu-devel@nongnu.org; Wed, 26 Jan 2011 23:54:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:25800)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PiJsM-0007Gm-Vs
	for qemu-devel@nongnu.org; Wed, 26 Jan 2011 23:54:31 -0500
Date: Thu, 27 Jan 2011 06:54:12 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110127045412.GA24451@redhat.com>
References: <852fa434bfd6eab6c97c2dcf58bd5773afb0d905.1296100102.git.yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <852fa434bfd6eab6c97c2dcf58bd5773afb0d905.1296100102.git.yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH] pci: typo in pcibus_get_dev_path()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: alex.williamson@redhat.com, qemu-devel@nongnu.org

On Thu, Jan 27, 2011 at 12:49:04PM +0900, Isaku Yamahata wrote:
> This patch fixes typo in pcibus_get_dev_path().
> Without this patch, the result of pcibus_get_dev_path() isn't unique.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Good catch, applied, thanks.

> ---
>  hw/pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/pci.c b/hw/pci.c
> index d2a0cee..b3d8ba5 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -2191,7 +2191,7 @@ static char *pcibus_get_dev_path(DeviceState *dev)
>      for (t = d; t; t = t->bus->parent_dev) {
>          p -= slot_len;
>          s = snprintf(slot, sizeof slot, ":%02x.%x",
> -                     PCI_SLOT(t->devfn), PCI_FUNC(d->devfn));
> +                     PCI_SLOT(t->devfn), PCI_FUNC(t->devfn));
>          assert(s == slot_len);
>          memcpy(p, slot, slot_len);
>      }
> -- 
> 1.7.1.1