* [Qemu-devel] [PATCH] pci: typo in pcibus_get_dev_path()
@ 2011-01-27 3:49 Isaku Yamahata
2011-01-27 4:54 ` [Qemu-devel] " Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Isaku Yamahata @ 2011-01-27 3:49 UTC (permalink / raw)
To: qemu-devel; +Cc: yamahata, alex.williamson, mst
This patch fixes typo in pcibus_get_dev_path().
Without this patch, the result of pcibus_get_dev_path() isn't unique.
Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
hw/pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index d2a0cee..b3d8ba5 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -2191,7 +2191,7 @@ static char *pcibus_get_dev_path(DeviceState *dev)
for (t = d; t; t = t->bus->parent_dev) {
p -= slot_len;
s = snprintf(slot, sizeof slot, ":%02x.%x",
- PCI_SLOT(t->devfn), PCI_FUNC(d->devfn));
+ PCI_SLOT(t->devfn), PCI_FUNC(t->devfn));
assert(s == slot_len);
memcpy(p, slot, slot_len);
}
--
1.7.1.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Qemu-devel] Re: [PATCH] pci: typo in pcibus_get_dev_path()
2011-01-27 3:49 [Qemu-devel] [PATCH] pci: typo in pcibus_get_dev_path() Isaku Yamahata
@ 2011-01-27 4:54 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2011-01-27 4:54 UTC (permalink / raw)
To: Isaku Yamahata; +Cc: alex.williamson, qemu-devel
On Thu, Jan 27, 2011 at 12:49:04PM +0900, Isaku Yamahata wrote:
> This patch fixes typo in pcibus_get_dev_path().
> Without this patch, the result of pcibus_get_dev_path() isn't unique.
>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Good catch, applied, thanks.
> ---
> hw/pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index d2a0cee..b3d8ba5 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -2191,7 +2191,7 @@ static char *pcibus_get_dev_path(DeviceState *dev)
> for (t = d; t; t = t->bus->parent_dev) {
> p -= slot_len;
> s = snprintf(slot, sizeof slot, ":%02x.%x",
> - PCI_SLOT(t->devfn), PCI_FUNC(d->devfn));
> + PCI_SLOT(t->devfn), PCI_FUNC(t->devfn));
> assert(s == slot_len);
> memcpy(p, slot, slot_len);
> }
> --
> 1.7.1.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-27 4:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-27 3:49 [Qemu-devel] [PATCH] pci: typo in pcibus_get_dev_path() Isaku Yamahata
2011-01-27 4:54 ` [Qemu-devel] " Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).