* [Qemu-devel] [PATCH] fix linuxboot.bin and multiboot.bin to not hijack int19
@ 2011-01-31 9:02 Gleb Natapov
2011-01-31 11:41 ` Alexander Graf
2011-02-01 23:02 ` Anthony Liguori
0 siblings, 2 replies; 6+ messages in thread
From: Gleb Natapov @ 2011-01-31 9:02 UTC (permalink / raw)
To: qemu-devel
Currently linuxboot.bin and multiboot.bin option roms override int19
vector to intercept boot process. No sane option rom should do that.
Provide bev entry instead that will be called by BIOS if option rom
is selected for booting.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
Note that this patch should be applied after qemu will upgrade to Seabios
that supports boot order. Otherwise there will be change in behavior
since option rom will not be selected for booting by default.
diff --git a/pc-bios/optionrom/linuxboot.S b/pc-bios/optionrom/linuxboot.S
index c109363..79b3ae8 100644
--- a/pc-bios/optionrom/linuxboot.S
+++ b/pc-bios/optionrom/linuxboot.S
@@ -22,6 +22,8 @@
#include "optionrom.h"
+#define PRODUCT "Linux loader"
+
BOOT_ROM_START
run_linuxboot:
diff --git a/pc-bios/optionrom/multiboot.S b/pc-bios/optionrom/multiboot.S
index 9131837..069c4e8 100644
--- a/pc-bios/optionrom/multiboot.S
+++ b/pc-bios/optionrom/multiboot.S
@@ -20,6 +20,8 @@
#include "optionrom.h"
+#define PRODUCT "multiboot loader"
+
#define MULTIBOOT_MAGIC 0x2badb002
#define GS_PROT_JUMP 0
diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h
index fbdd48a..95dbdda 100644
--- a/pc-bios/optionrom/optionrom.h
+++ b/pc-bios/optionrom/optionrom.h
@@ -93,31 +93,41 @@
.global _start; \
_start:; \
.short 0xaa55; \
- .byte (_end - _start) / 512;
+ .byte (_end - _start) / 512; \
+ lret; \
+ .org 0x18; \
+ .short 0; \
+ .short _pnph; \
+ _pnph: \
+ .ascii "$PnP"; \
+ .byte 0x01; \
+ .byte ( _pnph_len / 16 ); \
+ .short 0x0000; \
+ .byte 0x00; \
+ .byte 0x00; \
+ .long 0x00000000; \
+ .short _manufacturer; \
+ .short _product; \
+ .long 0x00000000; \
+ .short 0x0000; \
+ .short 0x0000; \
+ .short _bev; \
+ .short 0x0000; \
+ .short 0x0000; \
+ .equ _pnph_len, . - _pnph;
#define BOOT_ROM_START \
OPTION_ROM_START \
- push %eax; \
- push %ds; \
- \
- /* setup ds so we can access the IVT */ \
- xor %ax, %ax; \
- mov %ax, %ds; \
- \
- /* install our int 19 handler */ \
- movw $int19_handler, (0x19*4); \
- mov %cs, (0x19*4+2); \
- \
- pop %ds; \
- pop %eax; \
- lret; \
- \
- int19_handler:; \
+ _bev:; \
/* DS = CS */ \
movw %cs, %ax; \
movw %ax, %ds;
#define OPTION_ROM_END \
+ _manufacturer:; \
+ .asciz "QEMU"; \
+ _product:; \
+ .asciz PRODUCT; \
.align 512, 0; \
_end:
--
Gleb.
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] fix linuxboot.bin and multiboot.bin to not hijack int19
2011-01-31 9:02 [Qemu-devel] [PATCH] fix linuxboot.bin and multiboot.bin to not hijack int19 Gleb Natapov
@ 2011-01-31 11:41 ` Alexander Graf
2011-01-31 11:50 ` Gleb Natapov
2011-02-01 23:02 ` Anthony Liguori
1 sibling, 1 reply; 6+ messages in thread
From: Alexander Graf @ 2011-01-31 11:41 UTC (permalink / raw)
To: Gleb Natapov; +Cc: qemu-devel
On 31.01.2011, at 10:02, Gleb Natapov wrote:
> Currently linuxboot.bin and multiboot.bin option roms override int19
> vector to intercept boot process. No sane option rom should do that.
> Provide bev entry instead that will be called by BIOS if option rom
> is selected for booting.
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
>
> Note that this patch should be applied after qemu will upgrade to Seabios
> that supports boot order. Otherwise there will be change in behavior
> since option rom will not be selected for booting by default.
>
> diff --git a/pc-bios/optionrom/linuxboot.S b/pc-bios/optionrom/linuxboot.S
> index c109363..79b3ae8 100644
> --- a/pc-bios/optionrom/linuxboot.S
> +++ b/pc-bios/optionrom/linuxboot.S
> @@ -22,6 +22,8 @@
>
> #include "optionrom.h"
>
> +#define PRODUCT "Linux loader"
> +
> BOOT_ROM_START
>
> run_linuxboot:
> diff --git a/pc-bios/optionrom/multiboot.S b/pc-bios/optionrom/multiboot.S
> index 9131837..069c4e8 100644
> --- a/pc-bios/optionrom/multiboot.S
> +++ b/pc-bios/optionrom/multiboot.S
> @@ -20,6 +20,8 @@
>
> #include "optionrom.h"
>
> +#define PRODUCT "multiboot loader"
> +
> #define MULTIBOOT_MAGIC 0x2badb002
>
> #define GS_PROT_JUMP 0
> diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h
> index fbdd48a..95dbdda 100644
> --- a/pc-bios/optionrom/optionrom.h
> +++ b/pc-bios/optionrom/optionrom.h
> @@ -93,31 +93,41 @@
> .global _start; \
> _start:; \
> .short 0xaa55; \
> - .byte (_end - _start) / 512;
> + .byte (_end - _start) / 512; \
> + lret; \
> + .org 0x18; \
> + .short 0; \
> + .short _pnph; \
> + _pnph: \
> + .ascii "$PnP"; \
The idea behind the OPTION_ROM and BOOT_ROM split was to have a generic header that can be used as template for random option roms or boot roms alike. Your patch munges those two use-cases together by providing bev logic in the generic option rom part.
Please split it out into the BOOT_ROM macro, or - if necessary - create a new macro.
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] fix linuxboot.bin and multiboot.bin to not hijack int19
2011-01-31 11:41 ` Alexander Graf
@ 2011-01-31 11:50 ` Gleb Natapov
2011-01-31 11:53 ` Alexander Graf
0 siblings, 1 reply; 6+ messages in thread
From: Gleb Natapov @ 2011-01-31 11:50 UTC (permalink / raw)
To: Alexander Graf; +Cc: qemu-devel
On Mon, Jan 31, 2011 at 12:41:46PM +0100, Alexander Graf wrote:
> > Signed-off-by: Gleb Natapov <gleb@redhat.com>
> The idea behind the OPTION_ROM and BOOT_ROM split was to have a generic header that can be used as template for random option roms or boot roms alike. Your patch munges those two use-cases together by providing bev logic in the generic option rom part.
>
> Please split it out into the BOOT_ROM macro, or - if necessary - create a new macro.
>
>
Like this?
diff --git a/pc-bios/optionrom/linuxboot.S b/pc-bios/optionrom/linuxboot.S
index c109363..79b3ae8 100644
--- a/pc-bios/optionrom/linuxboot.S
+++ b/pc-bios/optionrom/linuxboot.S
@@ -22,6 +22,8 @@
#include "optionrom.h"
+#define PRODUCT "Linux loader"
+
BOOT_ROM_START
run_linuxboot:
diff --git a/pc-bios/optionrom/multiboot.S b/pc-bios/optionrom/multiboot.S
index 9131837..069c4e8 100644
--- a/pc-bios/optionrom/multiboot.S
+++ b/pc-bios/optionrom/multiboot.S
@@ -20,6 +20,8 @@
#include "optionrom.h"
+#define PRODUCT "multiboot loader"
+
#define MULTIBOOT_MAGIC 0x2badb002
#define GS_PROT_JUMP 0
diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h
index fbdd48a..2d4f40e 100644
--- a/pc-bios/optionrom/optionrom.h
+++ b/pc-bios/optionrom/optionrom.h
@@ -97,27 +97,37 @@
#define BOOT_ROM_START \
OPTION_ROM_START \
- push %eax; \
- push %ds; \
- \
- /* setup ds so we can access the IVT */ \
- xor %ax, %ax; \
- mov %ax, %ds; \
- \
- /* install our int 19 handler */ \
- movw $int19_handler, (0x19*4); \
- mov %cs, (0x19*4+2); \
- \
- pop %ds; \
- pop %eax; \
lret; \
- \
- int19_handler:; \
+ .org 0x18; \
+ .short 0; \
+ .short _pnph; \
+ _pnph: \
+ .ascii "$PnP"; \
+ .byte 0x01; \
+ .byte ( _pnph_len / 16 ); \
+ .short 0x0000; \
+ .byte 0x00; \
+ .byte 0x00; \
+ .long 0x00000000; \
+ .short _manufacturer; \
+ .short _product; \
+ .long 0x00000000; \
+ .short 0x0000; \
+ .short 0x0000; \
+ .short _bev; \
+ .short 0x0000; \
+ .short 0x0000; \
+ .equ _pnph_len, . - _pnph;
+ _bev:; \
/* DS = CS */ \
movw %cs, %ax; \
movw %ax, %ds;
#define OPTION_ROM_END \
+ _manufacturer:; \
+ .asciz "QEMU"; \
+ _product:; \
+ .asciz PRODUCT; \
.align 512, 0; \
_end:
--
Gleb.
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] fix linuxboot.bin and multiboot.bin to not hijack int19
2011-01-31 11:50 ` Gleb Natapov
@ 2011-01-31 11:53 ` Alexander Graf
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Graf @ 2011-01-31 11:53 UTC (permalink / raw)
To: Gleb Natapov; +Cc: qemu-devel
On 31.01.2011, at 12:50, Gleb Natapov wrote:
> On Mon, Jan 31, 2011 at 12:41:46PM +0100, Alexander Graf wrote:
>>> Signed-off-by: Gleb Natapov <gleb@redhat.com>
>> The idea behind the OPTION_ROM and BOOT_ROM split was to have a generic header that can be used as template for random option roms or boot roms alike. Your patch munges those two use-cases together by providing bev logic in the generic option rom part.
>>
>> Please split it out into the BOOT_ROM macro, or - if necessary - create a new macro.
>>
>>
> Like this?
>
> diff --git a/pc-bios/optionrom/linuxboot.S b/pc-bios/optionrom/linuxboot.S
> index c109363..79b3ae8 100644
> --- a/pc-bios/optionrom/linuxboot.S
> +++ b/pc-bios/optionrom/linuxboot.S
> @@ -22,6 +22,8 @@
>
> #include "optionrom.h"
>
> +#define PRODUCT "Linux loader"
Please make this BOOT_ROM_PRODUCT
Otherwise, yes, a lot better :)
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] fix linuxboot.bin and multiboot.bin to not hijack int19
2011-01-31 9:02 [Qemu-devel] [PATCH] fix linuxboot.bin and multiboot.bin to not hijack int19 Gleb Natapov
2011-01-31 11:41 ` Alexander Graf
@ 2011-02-01 23:02 ` Anthony Liguori
2011-02-02 5:06 ` Gleb Natapov
1 sibling, 1 reply; 6+ messages in thread
From: Anthony Liguori @ 2011-02-01 23:02 UTC (permalink / raw)
To: Gleb Natapov; +Cc: qemu-devel
On 01/31/2011 03:02 AM, Gleb Natapov wrote:
> Currently linuxboot.bin and multiboot.bin option roms override int19
> vector to intercept boot process. No sane option rom should do that.
> Provide bev entry instead that will be called by BIOS if option rom
> is selected for booting.
>
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
> ---
>
> Note that this patch should be applied after qemu will upgrade to Seabios
> that supports boot order. Otherwise there will be change in behavior
> since option rom will not be selected for booting by default.
>
I don't think there's a SeaBIOS release yet that includes the boot order
support.
Regards,
Anthony Liguori
> diff --git a/pc-bios/optionrom/linuxboot.S b/pc-bios/optionrom/linuxboot.S
> index c109363..79b3ae8 100644
> --- a/pc-bios/optionrom/linuxboot.S
> +++ b/pc-bios/optionrom/linuxboot.S
> @@ -22,6 +22,8 @@
>
> #include "optionrom.h"
>
> +#define PRODUCT "Linux loader"
> +
> BOOT_ROM_START
>
> run_linuxboot:
> diff --git a/pc-bios/optionrom/multiboot.S b/pc-bios/optionrom/multiboot.S
> index 9131837..069c4e8 100644
> --- a/pc-bios/optionrom/multiboot.S
> +++ b/pc-bios/optionrom/multiboot.S
> @@ -20,6 +20,8 @@
>
> #include "optionrom.h"
>
> +#define PRODUCT "multiboot loader"
> +
> #define MULTIBOOT_MAGIC 0x2badb002
>
> #define GS_PROT_JUMP 0
> diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h
> index fbdd48a..95dbdda 100644
> --- a/pc-bios/optionrom/optionrom.h
> +++ b/pc-bios/optionrom/optionrom.h
> @@ -93,31 +93,41 @@
> .global _start; \
> _start:; \
> .short 0xaa55; \
> - .byte (_end - _start) / 512;
> + .byte (_end - _start) / 512; \
> + lret; \
> + .org 0x18; \
> + .short 0; \
> + .short _pnph; \
> + _pnph: \
> + .ascii "$PnP"; \
> + .byte 0x01; \
> + .byte ( _pnph_len / 16 ); \
> + .short 0x0000; \
> + .byte 0x00; \
> + .byte 0x00; \
> + .long 0x00000000; \
> + .short _manufacturer; \
> + .short _product; \
> + .long 0x00000000; \
> + .short 0x0000; \
> + .short 0x0000; \
> + .short _bev; \
> + .short 0x0000; \
> + .short 0x0000; \
> + .equ _pnph_len, . - _pnph;
>
> #define BOOT_ROM_START \
> OPTION_ROM_START \
> - push %eax; \
> - push %ds; \
> - \
> - /* setup ds so we can access the IVT */ \
> - xor %ax, %ax; \
> - mov %ax, %ds; \
> - \
> - /* install our int 19 handler */ \
> - movw $int19_handler, (0x19*4); \
> - mov %cs, (0x19*4+2); \
> - \
> - pop %ds; \
> - pop %eax; \
> - lret; \
> - \
> - int19_handler:; \
> + _bev:; \
> /* DS = CS */ \
> movw %cs, %ax; \
> movw %ax, %ds;
>
> #define OPTION_ROM_END \
> + _manufacturer:; \
> + .asciz "QEMU"; \
> + _product:; \
> + .asciz PRODUCT; \
> .align 512, 0; \
> _end:
>
> --
> Gleb.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] fix linuxboot.bin and multiboot.bin to not hijack int19
2011-02-01 23:02 ` Anthony Liguori
@ 2011-02-02 5:06 ` Gleb Natapov
0 siblings, 0 replies; 6+ messages in thread
From: Gleb Natapov @ 2011-02-02 5:06 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
On Tue, Feb 01, 2011 at 05:02:55PM -0600, Anthony Liguori wrote:
> On 01/31/2011 03:02 AM, Gleb Natapov wrote:
> >Currently linuxboot.bin and multiboot.bin option roms override int19
> >vector to intercept boot process. No sane option rom should do that.
> >Provide bev entry instead that will be called by BIOS if option rom
> >is selected for booting.
> >
> >Signed-off-by: Gleb Natapov<gleb@redhat.com>
> >---
> >
> >Note that this patch should be applied after qemu will upgrade to Seabios
> >that supports boot order. Otherwise there will be change in behavior
> >since option rom will not be selected for booting by default.
>
> I don't think there's a SeaBIOS release yet that includes the boot
> order support.
>
I thought for AHCI support you are going to move to latest Seabios HEAD.
If this is not the case the patch should wait.
> Regards,
>
> Anthony Liguori
>
> >diff --git a/pc-bios/optionrom/linuxboot.S b/pc-bios/optionrom/linuxboot.S
> >index c109363..79b3ae8 100644
> >--- a/pc-bios/optionrom/linuxboot.S
> >+++ b/pc-bios/optionrom/linuxboot.S
> >@@ -22,6 +22,8 @@
> >
> > #include "optionrom.h"
> >
> >+#define PRODUCT "Linux loader"
> >+
> > BOOT_ROM_START
> >
> > run_linuxboot:
> >diff --git a/pc-bios/optionrom/multiboot.S b/pc-bios/optionrom/multiboot.S
> >index 9131837..069c4e8 100644
> >--- a/pc-bios/optionrom/multiboot.S
> >+++ b/pc-bios/optionrom/multiboot.S
> >@@ -20,6 +20,8 @@
> >
> > #include "optionrom.h"
> >
> >+#define PRODUCT "multiboot loader"
> >+
> > #define MULTIBOOT_MAGIC 0x2badb002
> >
> > #define GS_PROT_JUMP 0
> >diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionrom.h
> >index fbdd48a..95dbdda 100644
> >--- a/pc-bios/optionrom/optionrom.h
> >+++ b/pc-bios/optionrom/optionrom.h
> >@@ -93,31 +93,41 @@
> > .global _start; \
> > _start:; \
> > .short 0xaa55; \
> >- .byte (_end - _start) / 512;
> >+ .byte (_end - _start) / 512; \
> >+ lret; \
> >+ .org 0x18; \
> >+ .short 0; \
> >+ .short _pnph; \
> >+ _pnph: \
> >+ .ascii "$PnP"; \
> >+ .byte 0x01; \
> >+ .byte ( _pnph_len / 16 ); \
> >+ .short 0x0000; \
> >+ .byte 0x00; \
> >+ .byte 0x00; \
> >+ .long 0x00000000; \
> >+ .short _manufacturer; \
> >+ .short _product; \
> >+ .long 0x00000000; \
> >+ .short 0x0000; \
> >+ .short 0x0000; \
> >+ .short _bev; \
> >+ .short 0x0000; \
> >+ .short 0x0000; \
> >+ .equ _pnph_len, . - _pnph;
> >
> > #define BOOT_ROM_START \
> > OPTION_ROM_START \
> >- push %eax; \
> >- push %ds; \
> >- \
> >- /* setup ds so we can access the IVT */ \
> >- xor %ax, %ax; \
> >- mov %ax, %ds; \
> >- \
> >- /* install our int 19 handler */ \
> >- movw $int19_handler, (0x19*4); \
> >- mov %cs, (0x19*4+2); \
> >- \
> >- pop %ds; \
> >- pop %eax; \
> >- lret; \
> >- \
> >- int19_handler:; \
> >+ _bev:; \
> > /* DS = CS */ \
> > movw %cs, %ax; \
> > movw %ax, %ds;
> >
> > #define OPTION_ROM_END \
> >+ _manufacturer:; \
> >+ .asciz "QEMU"; \
> >+ _product:; \
> >+ .asciz PRODUCT; \
> > .align 512, 0; \
> > _end:
> >
> >--
> > Gleb.
> >
--
Gleb.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-02-02 5:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-31 9:02 [Qemu-devel] [PATCH] fix linuxboot.bin and multiboot.bin to not hijack int19 Gleb Natapov
2011-01-31 11:41 ` Alexander Graf
2011-01-31 11:50 ` Gleb Natapov
2011-01-31 11:53 ` Alexander Graf
2011-02-01 23:02 ` Anthony Liguori
2011-02-02 5:06 ` Gleb Natapov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).