From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45907 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PkGIS-0006km-1G
	for qemu-devel@nongnu.org; Tue, 01 Feb 2011 08:29:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PkGIQ-0001G5-Oy
	for qemu-devel@nongnu.org; Tue, 01 Feb 2011 08:29:27 -0500
Received: from mx1.redhat.com ([209.132.183.28]:61592)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1PkGIQ-0001Fy-Gl
	for qemu-devel@nongnu.org; Tue, 01 Feb 2011 08:29:26 -0500
Date: Tue, 1 Feb 2011 11:29:15 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20110201112915.56395b0a@doriath>
In-Reply-To: <4D412ACB.3050101@cn.fujitsu.com>
References: <4D412ACB.3050101@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH V6 1/4] nmi: convert cpu_index to cpu-index
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: aliguori@us.ibm.com, Jiangshan <eag0628@gmail.com>, Lai@gnu.org, kvm@vger.kernel.org, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

On Thu, 27 Jan 2011 16:20:27 +0800
Lai Jiangshan <laijs@cn.fujitsu.com> wrote:

> "cpu-index" which uses hyphen is better name.
> 
> Signed-off-by:  Lai Jiangshan <laijs@cn.fujitsu.com>

It looks ok from a quick pass, but I can't apply it on current master, what
commit HEAD did you?

Btw, please, do include the patch 0/0 with a general description about the
series and a small changelog between changes.

> ---
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 5d4cb9e..e43ac7c 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -721,7 +721,7 @@ ETEXI
>  #if defined(TARGET_I386)
>      {
>          .name       = "nmi",
> -        .args_type  = "cpu_index:i",
> +        .args_type  = "cpu-index:i",
>          .params     = "cpu",
>          .help       = "inject an NMI on the given CPU",
>          .mhandler.cmd = do_inject_nmi,
> diff --git a/monitor.c b/monitor.c
> index 27883f8..a916771 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2545,7 +2545,7 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict)
>  static void do_inject_nmi(Monitor *mon, const QDict *qdict)
>  {
>      CPUState *env;
> -    int cpu_index = qdict_get_int(qdict, "cpu_index");
> +    int cpu_index = qdict_get_int(qdict, "cpu-index");
>  
>      for (env = first_cpu; env != NULL; env = env->next_cpu)
>          if (env->cpu_index == cpu_index) {
>