From: Marcelo Tosatti <mtosatti@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: Jan Kiszka <jan.kiszka@web.de>,
qemu-devel@nongnu.org, kvm@vger.kernel.org, avi@redhat.com
Subject: [Qemu-devel] Re: [PATCH v2] make tsc stable over migration and machine start
Date: Thu, 3 Feb 2011 14:00:25 -0200 [thread overview]
Message-ID: <20110203160025.GA8092@amt.cnet> (raw)
In-Reply-To: <1296648980-28883-1-git-send-email-glommer@redhat.com>
On Wed, Feb 02, 2011 at 07:16:20AM -0500, Glauber Costa wrote:
> If the machine is stopped, we should not record two different tsc values
> upon a save operation. The same problem happens with kvmclock.
>
> But kvmclock is taking a different diretion, being now seen as a separate
> device. Since this is unlikely to happen with the tsc, I am taking the
> approach here of simply registering a handler for state change, and
> using a per-CPUState variable that prevents double updates for the TSC.
>
> Signed-off-by: Glauber Costa <glommer@redhat.com>
> CC: Jan Kiszka <jan.kiszka@web.de>
>
> ---
> v2: updated tsc validation logic, as asked by Jan
> ---
> target-i386/cpu.h | 1 +
> target-i386/kvm.c | 18 +++++++++++++++++-
> 2 files changed, 18 insertions(+), 1 deletions(-)
Please regenerate against uq/master.
prev parent reply other threads:[~2011-02-03 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 12:16 [Qemu-devel] [PATCH v2] make tsc stable over migration and machine start Glauber Costa
2011-02-02 13:07 ` [Qemu-devel] " Jan Kiszka
2011-02-03 16:00 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110203160025.GA8092@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).