From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51033 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pl2C6-0002f0-71 for qemu-devel@nongnu.org; Thu, 03 Feb 2011 11:38:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pl2C4-0000oA-OB for qemu-devel@nongnu.org; Thu, 03 Feb 2011 11:38:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pl2C4-0000nZ-GB for qemu-devel@nongnu.org; Thu, 03 Feb 2011 11:38:04 -0500 Date: Thu, 3 Feb 2011 18:37:48 +0200 From: "Michael S. Tsirkin" Message-ID: <20110203163748.GA10461@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] tap: minor code cleanup List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Anthony Liguori remove a confusing comment. TAP_DEFAULT_SNDBUF 0 is later translated to INT_MAX, so let's set that value directly. Signed-off-by: Michael S. Tsirkin --- net/tap-linux.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/net/tap-linux.c b/net/tap-linux.c index 00f84d4..b8c0f3b 100644 --- a/net/tap-linux.c +++ b/net/tap-linux.c @@ -84,13 +84,8 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr, int vnet_hdr_required * Unfortunately when it's enabled, and packets are sent * to other guests on the same host, the receiver * can lock up the transmitter indefinitely. - * - * To avoid packet loss, sndbuf should be set to a value lower than the tx - * queue capacity of any destination network interface. - * Ethernet NICs generally have txqueuelen=1000, so 1Mb is - * a good value, given a 1500 byte MTU. */ -#define TAP_DEFAULT_SNDBUF 0 +#define TAP_DEFAULT_SNDBUF INT_MAX int tap_set_sndbuf(int fd, QemuOpts *opts) { -- 1.7.3.2.91.g446ac